Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(editor): Send workflow context to assistant store #11135

Merged
merged 14 commits into from
Oct 10, 2024

Conversation

MiloradFilipovic
Copy link
Contributor

@MiloradFilipovic MiloradFilipovic commented Oct 7, 2024

Summary

Sending workflow and execution data in AI assistant support chat requests.

➡️ Accompanying AI Service PR

Related Linear tickets, Github issues, and Community forum posts

Closes ADO-2661
Fixes ADO-2711

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@MiloradFilipovic MiloradFilipovic self-assigned this Oct 7, 2024
@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Oct 7, 2024
RicardoE105
RicardoE105 previously approved these changes Oct 10, 2024
Copy link
Contributor

@RicardoE105 RicardoE105 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🥇

Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

Copy link

cypress bot commented Oct 10, 2024

n8n    Run #7300

Run Properties:  status check passed Passed #7300  •  git commit 861216cec4: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 MiloradFilipovic 🗃️ e2e/*
Project n8n
Run status status check passed Passed #7300
Run duration 04m 27s
Commit git commit 861216cec4: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 MiloradFilipovic 🗃️ e2e/*
Committer Milorad FIlipović
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 3
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 439

@RicardoE105
Copy link
Contributor

Looks like we need to sync with master to resolve the e2e issues

CharlieKolb
CharlieKolb previously approved these changes Oct 10, 2024
Copy link
Contributor

@CharlieKolb CharlieKolb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reapproving due to staleness

Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

CharlieKolb
CharlieKolb previously approved these changes Oct 10, 2024
Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

Copy link
Contributor

✅ All Cypress E2E specs passed

@MiloradFilipovic MiloradFilipovic merged commit fade9e4 into master Oct 10, 2024
34 checks passed
@MiloradFilipovic MiloradFilipovic deleted the ADO-2661-send-workflow-context-to-assistant branch October 10, 2024 11:13
@github-actions github-actions bot mentioned this pull request Oct 16, 2024
@janober
Copy link
Member

janober commented Oct 16, 2024

Got released with [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants