fix(Edit Image Node): Fix Text operation by setting Arial as default font #11125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ayatnkw
changed the title
n8n-assistant
bot
added
n8n team
ShireenMissi
reviewed
Oct 7, 2024
ShireenMissi
reviewed
Oct 7, 2024
Co-authored-by: Shireen Missi <[email protected]>
|
|
n8n
|
||||||||||||||||||||||||||||
| Project |
n8n
|
| Branch Review |
master
|
| Run status |
|
| Run duration | 04m 26s |
| Commit |
|
| Committer | aya |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
461
|
| View all changes introduced in this branch ↗︎ | |
|
✅ All Cypress E2E specs passed |
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The Edit Image node's text operation doesn't work because the default font is not set. This PR fixes this by setting the default font to Arial if it exists in the system fonts.
Related Linear tickets, Github issues, and Community forum posts
#10751 (Closed this to avoid moving the Font option into required node parameters to prevent breaking changes)
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)