-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(editor): Format action names properly when action is not defined #11030
Merged
RicardoE105
merged 4 commits into
master
from
ado-2658-nodes-panel-triggers-action-name-in-nodes-panel-should-be
Oct 2, 2024
Merged
fix(editor): Format action names properly when action is not defined #11030
RicardoE105
merged 4 commits into
master
from
ado-2658-nodes-panel-triggers-action-name-in-nodes-panel-should-be
Oct 2, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RicardoE105
changed the title
Capitalize name if action property is not present
fix(editor): Capitalize name if action property is not present
Oct 1, 2024
n8n-assistant
bot
added
n8n team
Authored by the n8n team
ui
Enhancement in /editor-ui or /design-system
labels
Oct 1, 2024
mutdmour
reviewed
Oct 1, 2024
packages/editor-ui/src/components/Node/NodeCreator/composables/useActionsGeneration.ts
Outdated
Show resolved
Hide resolved
RicardoE105
changed the title
fix(editor): Capitalize name if action property is not present
fix(editor): Format action names property when action is not defined
Oct 1, 2024
RicardoE105
changed the title
fix(editor): Format action names property when action is not defined
fix(editor): Format action names properly when action is not defined
Oct 1, 2024
RicardoE105
force-pushed
the
ado-2658-nodes-panel-triggers-action-name-in-nodes-panel-should-be
branch
from
October 1, 2024 17:11
f08dec6
to
56d2326
Compare
RicardoE105
force-pushed
the
ado-2658-nodes-panel-triggers-action-name-in-nodes-panel-should-be
branch
from
October 1, 2024 17:24
56d2326
to
98a9541
Compare
gandreini
previously approved these changes
Oct 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
|
n8n Run #7131
Run Properties:
|
Project |
n8n
|
Branch Review |
ado-2658-nodes-panel-triggers-action-name-in-nodes-panel-should-be
|
Run status |
Passed #7131
|
Run duration | 04m 30s |
Commit |
4558eaa672: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 RicardoE105 🗃️ e2e/*
|
Committer | Ricardo Espinoza |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
0
|
Pending |
0
|
Skipped |
0
|
Passing |
437
|
View all changes introduced in this branch ↗︎ |
MiloradFilipovic
approved these changes
Oct 2, 2024
✅ All Cypress E2E specs passed |
RicardoE105
deleted the
ado-2658-nodes-panel-triggers-action-name-in-nodes-panel-should-be
branch
October 2, 2024 12:16
Merged
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Before
Now
Review / Merge checklist
release/backport
(if the PR is an urgent fix that needs to be backported)