Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editor): Format action names properly when action is not defined #11030

Conversation

RicardoE105
Copy link
Contributor

@RicardoE105 RicardoE105 commented Oct 1, 2024

Summary

Before

CleanShot 2024-10-01 at 11 36 20@1X

Now

CleanShot 2024-10-01 at 11 44 27@1X

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@RicardoE105 RicardoE105 changed the title Capitalize name if action property is not present fix(editor): Capitalize name if action property is not present Oct 1, 2024
@RicardoE105 RicardoE105 marked this pull request as draft October 1, 2024 02:05
@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Oct 1, 2024
@RicardoE105 RicardoE105 changed the title fix(editor): Capitalize name if action property is not present fix(editor): Format action names property when action is not defined Oct 1, 2024
@RicardoE105 RicardoE105 marked this pull request as ready for review October 1, 2024 15:34
@RicardoE105 RicardoE105 changed the title fix(editor): Format action names property when action is not defined fix(editor): Format action names properly when action is not defined Oct 1, 2024
@RicardoE105 RicardoE105 force-pushed the ado-2658-nodes-panel-triggers-action-name-in-nodes-panel-should-be branch from f08dec6 to 56d2326 Compare October 1, 2024 17:11
@RicardoE105 RicardoE105 force-pushed the ado-2658-nodes-panel-triggers-action-name-in-nodes-panel-should-be branch from 56d2326 to 98a9541 Compare October 1, 2024 17:24
gandreini
gandreini previously approved these changes Oct 2, 2024
Copy link
Contributor

@gandreini gandreini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Copy link
Contributor

github-actions bot commented Oct 2, 2024

⚠️ Some Cypress E2E specs are failing, please fix them before merging

Copy link

cypress bot commented Oct 2, 2024

n8n    Run #7131

Run Properties:  status check passed Passed #7131  •  git commit 4558eaa672: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 RicardoE105 🗃️ e2e/*
Project n8n
Branch Review ado-2658-nodes-panel-triggers-action-name-in-nodes-panel-should-be
Run status status check passed Passed #7131
Run duration 04m 30s
Commit git commit 4558eaa672: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 RicardoE105 🗃️ e2e/*
Committer Ricardo Espinoza
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 437
View all changes introduced in this branch ↗︎

Copy link
Contributor

github-actions bot commented Oct 2, 2024

✅ All Cypress E2E specs passed

@RicardoE105 RicardoE105 merged commit 9c43fb3 into master Oct 2, 2024
33 checks passed
@RicardoE105 RicardoE105 deleted the ado-2658-nodes-panel-triggers-action-name-in-nodes-panel-should-be branch October 2, 2024 12:16
@github-actions github-actions bot mentioned this pull request Oct 2, 2024
@janober
Copy link
Member

janober commented Oct 2, 2024

Got released with [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants