Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(editor): Fix design system form component sizing #10961

Merged
merged 1 commit into from
Sep 25, 2024
Merged

fix(editor): Fix design system form component sizing #10961

merged 1 commit into from
Sep 25, 2024

Conversation

cstuncsik
Copy link
Contributor

Summary

Some design system form components accepting props for sizing but they're not utilizing them

Related Linear tickets, Github issues, and Community forum posts

PAY-1992

Review / Merge checklist

  • PR title and summary are descriptive.
  • Tests included.
  • PR Labeled with release/backport

@cstuncsik cstuncsik requested a review from r00gm September 25, 2024 08:51
@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Sep 25, 2024
@cypress Cypress
Copy link

cypress bot commented Sep 25, 2024

n8n    Run #7030

Run Properties:  status check passed Passed #7030  •  git commit 8fd1923ebe: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 cstuncsik 🗃️ e2e/*
Project n8n
Branch Review pay-1992-fix-design-system-forminput-component-sizing
Run status status check passed Passed #7030
Run duration 04m 23s
Commit git commit 8fd1923ebe: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 cstuncsik 🗃️ e2e/*
Committer Csaba Tuncsik
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 2
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 432
View all changes introduced in this branch ↗︎

@github-actions GitHub Actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@cstuncsik cstuncsik merged commit cf153ea into master Sep 25, 2024
33 checks passed
@cstuncsik cstuncsik deleted the pay-1992-fix-design-system-forminput-component-sizing branch September 25, 2024 09:30
@github-actions github-actions bot mentioned this pull request Sep 25, 2024
Merged
@janober
Copy link
Member

janober commented Sep 25, 2024

Got released with [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r00gm r00gm r00gm approved these changes

Assignees
No one assigned
Labels
n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cstuncsik @janober @r00gm