Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Google Sheets Node): Updating on row_number using automatic matching #10940

Conversation

michael-radency
Copy link
Contributor

Summary

fix when updating on row_number using automatic matching

Related Linear tickets, Github issues, and Community forum posts

https://linear.app/n8n/issue/NODE-1687/google-sheets-updating-on-row-number-using-automatic-matching-doesnt

@michael-radency michael-radency added n8n team Authored by the n8n team node/issue Issue with a node labels Sep 24, 2024
…google-sheets-updating-on-row_number-using-automatic
@michael-radency michael-radency changed the title fix(Google Sheets): Updating on row_number using automatic matching fix(Google Sheets Node): Updating on row_number using automatic matching Sep 25, 2024
Copy link
Contributor

@ShireenMissi ShireenMissi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

Copy link

cypress bot commented Sep 25, 2024

n8n    Run #7038

Run Properties:  status check passed Passed #7038  •  git commit 6b8f923de9: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 michael-radency 🗃️ e2e/*
Project n8n
Branch Review node-1687-google-sheets-updating-on-row_number-using-automatic
Run status status check passed Passed #7038
Run duration 04m 35s
Commit git commit 6b8f923de9: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 michael-radency 🗃️ e2e/*
Committer Michael Kret
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 3
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 432
View all changes introduced in this branch ↗︎

Copy link
Contributor

✅ All Cypress E2E specs passed

@ShireenMissi ShireenMissi merged commit ed91495 into master Sep 25, 2024
43 checks passed
@ShireenMissi ShireenMissi deleted the node-1687-google-sheets-updating-on-row_number-using-automatic branch September 25, 2024 12:50
This was referenced Oct 2, 2024
@janober
Copy link
Member

janober commented Oct 2, 2024

Got released with [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team node/issue Issue with a node Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants