Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editor): Fix source control push modal checkboxes #10910

Conversation

cstuncsik
Copy link
Contributor

Summary

Checkboxes of the modal to push workflows are not clickable

Related Linear tickets, Github issues, and Community forum posts

PAY-1906

Review / Merge checklist

  • PR title and summary are descriptive
  • Tests included.
  • PR Labeled with release/backport

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Sep 20, 2024
@cstuncsik cstuncsik marked this pull request as ready for review September 23, 2024 12:28
@cstuncsik cstuncsik requested a review from r00gm September 23, 2024 12:28
Copy link
Contributor

@r00gm r00gm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests! hurray!!

Copy link

cypress bot commented Sep 24, 2024

n8n    Run #7011

Run Properties:  status check passed Passed #7011  •  git commit 6318166a83: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 cstuncsik 🗃️ e2e/*
Project n8n
Branch Review pay-1906-bug-environments-checkboxes-of-the-modal-to-push-workflows
Run status status check passed Passed #7011
Run duration 04m 27s
Commit git commit 6318166a83: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 cstuncsik 🗃️ e2e/*
Committer Csaba Tuncsik
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 2
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 430
View all changes introduced in this branch ↗︎

Copy link
Contributor

✅ All Cypress E2E specs passed

@cstuncsik cstuncsik merged commit 8db8817 into master Sep 24, 2024
33 checks passed
@cstuncsik cstuncsik deleted the pay-1906-bug-environments-checkboxes-of-the-modal-to-push-workflows branch September 24, 2024 09:40
@github-actions github-actions bot mentioned this pull request Sep 25, 2024
@janober
Copy link
Member

janober commented Sep 25, 2024

Got released with [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants