feat(Gong Node): New node #10777
Merged
feat(Gong Node): New node #10777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8n-assistant
bot
added
community
|
Hey @feelgood-interface, Thanks for the PR, We have created "GHC-224" as the internal reference to get this reviewed. One of us will be in touch if there are any changes needed, in most cases this is normally within a couple of weeks but it depends on the current workload of the team. |
Comment on lines
39
to
52
| async function ( | ||
| this: IExecuteSingleFunctions, | ||
| data: INodeExecutionData[], | ||
| response: IN8nHttpFullResponse, | ||
| ): Promise<INodeExecutionData[]> { | ||
| if (response.statusCode === 404) { | ||
| throw new NodeApiError(this.getNode(), response as unknown as JsonObject, { | ||
| message: "The required user doesn't match any existing one", | ||
| description: | ||
| "Double-check the value in the parameter 'User to Get' and try again", | ||
| }); | ||
| } | ||
| return await sendErrorPostReceive.call(this, data, response); | ||
| }, |
There was a problem hiding this comment.
probably better to extract to a GenericFunctions, and in other places too
There was a problem hiding this comment.
Thanks @feelgood-interface for the PR, tested manually and it works 🎉
left a few comments, nothing major just some refactoring and minor corrections
Merged
|
Got released with |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add new Gong node.
Related Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/NODE-1795/gong-node
Gong API Documentation