Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editor): Increase connector snap radius #10757

Merged

Conversation

r00gm
Copy link
Contributor

@r00gm r00gm commented Sep 10, 2024

Summary

Added VueFlow configuration to increase connector's snap radius to mimic V1 behaviour

Related Linear tickets, Github issues, and Community forum posts

https://linear.app/n8n/issue/N8N-7678/make-connector-snap-to-handle-with-a-bigger-target-area

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@r00gm r00gm marked this pull request as ready for review September 10, 2024 12:00
@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Sep 10, 2024
@r00gm r00gm changed the title fix(editor): Increase connector span radius fix(editor): Increase connector snap radius Sep 10, 2024
Copy link
Contributor

✅ All Cypress E2E specs passed

Copy link

cypress bot commented Sep 10, 2024

n8n    Run #6807

Run Properties:  status check passed Passed #6807  •  git commit 0e8e0ba05a: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 r00gm 🗃️ e2e/*
Project n8n
Branch Review n8n-7678-make-connector-snap-to-handle-with-a-bigger-target-area
Run status status check passed Passed #6807
Run duration 04m 43s
Commit git commit 0e8e0ba05a: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 r00gm 🗃️ e2e/*
Committer r00gm
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 425
View all changes introduced in this branch ↗︎

@r00gm r00gm merged commit 297b668 into master Sep 10, 2024
33 checks passed
@r00gm r00gm deleted the n8n-7678-make-connector-snap-to-handle-with-a-bigger-target-area branch September 10, 2024 14:22
@github-actions github-actions bot mentioned this pull request Sep 11, 2024
@Joffcom
Copy link
Member

Joffcom commented Sep 11, 2024

Got released with [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants