Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(editor): Add lint for $('Node').item in runOnceForAllItems mode #10743

Merged
merged 2 commits into from
Sep 10, 2024
Merged

feat(editor): Add lint for $('Node').item in runOnceForAllItems mode #10743

merged 2 commits into from
Sep 10, 2024

Conversation

elsmr
Copy link
Member

@elsmr elsmr commented Sep 9, 2024 •
edited by ShireenMissi
Loading

Summary

image

Related Linear tickets, Github issues, and Community forum posts

https://linear.app/n8n/issue/NODE-1588/code-node-throw-an-error-when-using-dollaritem-in-run-once-for-all

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@n8n-assistant n8n-assistant bot added community Authored by a community member node/improvement New feature or request labels Sep 10, 2024
@Joffcom Joffcom added n8n team Authored by the n8n team and removed community Authored by a community member labels Sep 10, 2024
ShireenMissi
ShireenMissi approved these changes Sep 10, 2024
View reviewed changes
Copy link
Contributor

@ShireenMissi ShireenMissi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@cypress Cypress
Copy link

cypress bot commented Sep 10, 2024

n8n    Run #6808

Run Properties:  status check passed Passed #6808  •  git commit fd08aac233: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 elsmr 🗃️ e2e/*
Project n8n
Branch Review node-1588-code-node-throw-an-error-when-using-item-in-run-once-for-all
Run status status check passed Passed #6808
Run duration 04m 46s
Commit git commit fd08aac233: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 elsmr 🗃️ e2e/*
Committer Elias Meire
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 427
View all changes introduced in this branch ↗︎

@github-actions GitHub Actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@ShireenMissi ShireenMissi merged commit 1b04be1 into master Sep 10, 2024
34 checks passed
@ShireenMissi ShireenMissi deleted the node-1588-code-node-throw-an-error-when-using-item-in-run-once-for-all branch September 10, 2024 15:26
@github-actions github-actions bot mentioned this pull request Sep 11, 2024
Merged
@Joffcom
Copy link
Member

Joffcom commented Sep 11, 2024

Got released with [email protected]

riascho pushed a commit that referenced this pull request Sep 23, 2024
@elsmr @riascho
feat(editor): Add lint for $('Node').item in runOnceForAllItems mode (#…
0705d7e 
…10743)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShireenMissi ShireenMissi ShireenMissi approved these changes

Assignees
No one assigned
Labels
n8n team Authored by the n8n team node/improvement New feature or request Released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@elsmr @Joffcom @ShireenMissi