Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Todoist Node): Make Section Name optional in Move Task operation #10732

Merged
merged 8 commits into from
Sep 25, 2024

Conversation

ayatnkw
Copy link
Contributor

@ayatnkw ayatnkw commented Sep 9, 2024

Summary

When using a Todoist "Move a task" node, the section ID value is a required field in n8n, but this field is not required in the Todoist API. Leaving it blank gives a validation error: The value "" is not supported.

This PR fixes this by moving the SectionID under additional fields. It also adds ParentID as an additional field.

Related Linear tickets, Github issues, and Community forum posts

Related Github issue: #7478

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@n8n-assistant n8n-assistant bot added the n8n team Authored by the n8n team label Sep 10, 2024
@ayatnkw ayatnkw marked this pull request as ready for review September 11, 2024 06:16
Copy link
Contributor

@ShireenMissi ShireenMissi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@ShireenMissi ShireenMissi added the tests-needed This PR needs additional tests label Sep 25, 2024
Copy link

cypress bot commented Sep 25, 2024

n8n    Run #7041

Run Properties:  status check passed Passed #7041  •  git commit dcffd27509: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 ayatnkw 🗃️ e2e/*
Project n8n
Branch Review node-874-todoist-move-task-needs-updating
Run status status check passed Passed #7041
Run duration 04m 24s
Commit git commit dcffd27509: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 ayatnkw 🗃️ e2e/*
Committer Aya Tanikawa
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 432
View all changes introduced in this branch ↗︎

Copy link
Contributor

✅ All Cypress E2E specs passed

@ShireenMissi ShireenMissi merged commit 799006a into master Sep 25, 2024
33 checks passed
@ShireenMissi ShireenMissi deleted the node-874-todoist-move-task-needs-updating branch September 25, 2024 14:29
This was referenced Oct 2, 2024
@janober
Copy link
Member

janober commented Oct 2, 2024

Got released with [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team Released tests-needed This PR needs additional tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants