-
Notifications
You must be signed in to change notification settings - Fork 8.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(YouTube Node): Fix Date filters #10725
Merged
ShireenMissi
merged 1 commit into
master
from
node-1288-youtube-published-after-published-before-date-filters-error
Sep 11, 2024
Merged
fix(YouTube Node): Fix Date filters #10725
ShireenMissi
merged 1 commit into
master
from
node-1288-youtube-published-after-published-before-date-filters-error
Sep 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShireenMissi
changed the title
fix(Youtube Node): Fix Date filters
fix(YouTube Node): Fix Date filters
Sep 6, 2024
elsmr
reviewed
Sep 9, 2024
n8n-assistant
bot
added
n8n team
Authored by the n8n team
node/improvement
New feature or request
labels
Sep 10, 2024
ShireenMissi
force-pushed
the
node-1288-youtube-published-after-published-before-date-filters-error
branch
from
September 10, 2024 16:41
a3269e3
to
3bed6f2
Compare
elsmr
approved these changes
Sep 11, 2024
n8n Run #6824
Run Properties:
|
Project |
n8n
|
Branch Review |
node-1288-youtube-published-after-published-before-date-filters-error
|
Run status |
Passed #6824
|
Run duration | 04m 42s |
Commit |
3bed6f2b3a: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 ShireenMissi 🗃️ e2e/*
|
Committer | Shireen Missi |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
0
|
Pending |
0
|
Skipped |
0
|
Passing |
425
|
View all changes introduced in this branch ↗︎ |
✅ All Cypress E2E specs passed |
ShireenMissi
deleted the
node-1288-youtube-published-after-published-before-date-filters-error
branch
September 11, 2024 08:44
Merged
Got released with |
riascho
pushed a commit
that referenced
this pull request
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the date format for published before and published after filters to include timezones
Related Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/NODE-1288/youtube-published-after-published-before-date-filters-error
#9007
Review / Merge checklist
release/backport
(if the PR is an urgent fix that needs to be backported)