Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(YouTube Node): Fix Date filters #10725

Conversation

ShireenMissi
Copy link
Contributor

@ShireenMissi ShireenMissi commented Sep 6, 2024

Summary

This PR fixes the date format for published before and published after filters to include timezones

Related Linear tickets, Github issues, and Community forum posts

https://linear.app/n8n/issue/NODE-1288/youtube-published-after-published-before-date-filters-error

#9007

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@ShireenMissi ShireenMissi changed the title fix(Youtube Node): Fix Date filters fix(YouTube Node): Fix Date filters Sep 6, 2024
@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team node/improvement New feature or request labels Sep 10, 2024
@ShireenMissi ShireenMissi force-pushed the node-1288-youtube-published-after-published-before-date-filters-error branch from a3269e3 to 3bed6f2 Compare September 10, 2024 16:41
Copy link

cypress bot commented Sep 11, 2024

n8n    Run #6824

Run Properties:  status check passed Passed #6824  •  git commit 3bed6f2b3a: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 ShireenMissi 🗃️ e2e/*
Project n8n
Branch Review node-1288-youtube-published-after-published-before-date-filters-error
Run status status check passed Passed #6824
Run duration 04m 42s
Commit git commit 3bed6f2b3a: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 ShireenMissi 🗃️ e2e/*
Committer Shireen Missi
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 425
View all changes introduced in this branch ↗︎

Copy link
Contributor

✅ All Cypress E2E specs passed

@ShireenMissi ShireenMissi merged commit 21936c8 into master Sep 11, 2024
32 checks passed
@ShireenMissi ShireenMissi deleted the node-1288-youtube-published-after-published-before-date-filters-error branch September 11, 2024 08:44
@github-actions github-actions bot mentioned this pull request Sep 11, 2024
@Joffcom
Copy link
Member

Joffcom commented Sep 11, 2024

Got released with [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team node/improvement New feature or request Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants