Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Prevent AI assistant session reset when workflow is saved #10707

Merged
merged 3 commits into from
Sep 6, 2024
Merged

fix: Prevent AI assistant session reset when workflow is saved #10707

merged 3 commits into from
Sep 6, 2024

Conversation

MiloradFilipovic
Copy link
Contributor

Summary

  1. Preventing AI assistant session reset when workflows are saved
  2. Adding node_type to the Assistant session started telemetry event
  3. Minor fix: Preventing user avatar from turning square when modals are open
image

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@MiloradFilipovic MiloradFilipovic added the release/backport Changes that need to be backported to older releases. label Sep 6, 2024
@MiloradFilipovic MiloradFilipovic self-assigned this Sep 6, 2024
@cypress Cypress
Copy link

cypress bot commented Sep 6, 2024

n8n    Run #6765

Run Properties:  status check passed Passed #6765  •  git commit 2c34163b3d: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 MiloradFilipovic 🗃️ e2e/*
Project n8n
Branch Review ai-assistant-patch
Run status status check passed Passed #6765
Run duration 04m 41s
Commit git commit 2c34163b3d: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 MiloradFilipovic 🗃️ e2e/*
Committer Milorad Filipovic
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 425
View all changes introduced in this branch ↗︎

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 6, 2024

✅ All Cypress E2E specs passed

@MiloradFilipovic MiloradFilipovic merged commit 91d9be2 into master Sep 6, 2024
32 checks passed
@MiloradFilipovic MiloradFilipovic deleted the ai-assistant-patch branch September 6, 2024 09:06
tomi pushed a commit that referenced this pull request Sep 6, 2024
@MiloradFilipovic @tomi
fix: Prevent AI assistant session reset when workflow is saved (#10707)
02d3873
@github-actions github-actions bot mentioned this pull request Sep 6, 2024
Merged
@janober
Copy link
Member

janober commented Sep 6, 2024

Got released with [email protected]

@github-actions github-actions bot mentioned this pull request Sep 11, 2024
Merged
riascho pushed a commit that referenced this pull request Sep 23, 2024
@MiloradFilipovic @riascho
fix: Prevent AI assistant session reset when workflow is saved (#10707)
5c67124
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mutdmour mutdmour mutdmour approved these changes

Assignees

@MiloradFilipovic MiloradFilipovic

Labels
release/backport Changes that need to be backported to older releases. Released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MiloradFilipovic @janober @mutdmour