fix(editor): Auto-focus expression input when switching from "fixed" mode #10686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mutdmour
reviewed
Sep 5, 2024
| @@ -941,6 +941,14 @@ watch(remoteParameterOptionsLoading, () => { | |||
| tempValue.value = displayValue.value as string; | |||
| }); | |||
|
|
|||
| // Focus input field when changing from fixed value to expression | |||
| watch(isModelValueExpression, async (isExpression, wasExpression) => { | |||
There was a problem hiding this comment.
I'm not sure how to test the focused state of the inline expression input. It's using Codemirror; hence, it's rendered as a div, not an input
elsmr
approved these changes
Sep 5, 2024
n8n
|
||||||||||||||||||||||||||||
| Project |
n8n
|
| Branch Review |
autofocus-expression-after-switching
|
| Run status |
|
| Run duration | 04m 51s |
| Commit |
|
| Committer | Oleg Ivaniv |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
424
|
| View all changes introduced in this branch ↗︎ | |
|
✅ All Cypress E2E specs passed |
Merged
|
Got released with |
riascho
pushed a commit
that referenced
this pull request
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
A small fix to retain input focus when switching to expression mode.
CleanShot.2024-09-05.at.13.20.29.mp4
Related Linear tickets, Github issues, and Community forum posts
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)