Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(editor): Logs markdown block improvements #10681

Conversation

burivuhster
Copy link
Contributor

@burivuhster burivuhster commented Sep 5, 2024

Summary

  • Fix raw text showing as a markdown code block
  • Enable syntax highlighting for markdown code blocks in logs

Related Linear tickets, Github issues, and Community forum posts

https://linear.app/n8n/issue/AI-325/improve-markdown-rendering-in-the-ai-log-view-add-code-highlight

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Sep 5, 2024
@burivuhster burivuhster marked this pull request as ready for review September 5, 2024 10:57
@OlegIvaniv
Copy link
Contributor

@burivuhster Looks so much better! One thing I noticed — there's still weird highlighting happening for nested code elements. Could we get rid of that?

CleanShot.2024-09-05.at.15.11.30.mp4

@burivuhster
Copy link
Contributor Author

image
I copied the background color from the left chat panel. What do you think?

Copy link
Contributor

@OlegIvaniv OlegIvaniv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Copy link

cypress bot commented Sep 5, 2024

n8n    Run #6761

Run Properties:  status check passed Passed #6761  •  git commit 7de40ffde9: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 burivuhster 🗃️ e2e/*
Project n8n
Branch Review ai-325-improve-markdown-rendering-in-the-ai-log-view-add-code
Run status status check passed Passed #6761
Run duration 04m 51s
Commit git commit 7de40ffde9: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 burivuhster 🗃️ e2e/*
Committer Eugene Molodkin
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 424
View all changes introduced in this branch ↗︎

Copy link
Contributor

github-actions bot commented Sep 5, 2024

✅ All Cypress E2E specs passed

@burivuhster burivuhster merged commit db6e832 into master Sep 6, 2024
32 checks passed
@burivuhster burivuhster deleted the ai-325-improve-markdown-rendering-in-the-ai-log-view-add-code branch September 6, 2024 07:18
@github-actions github-actions bot mentioned this pull request Sep 11, 2024
@Joffcom
Copy link
Member

Joffcom commented Sep 11, 2024

Got released with [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants