Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editor): Add sticky note readonly state in new canvas #10678

Conversation

alexgrozav
Copy link
Member

Summary

  • Hides resizer when readonly
  • Removes color change from node toolbar when readonly

Related Linear tickets, Github issues, and Community forum posts

https://linear.app/n8n/issue/N8N-7679/disable-sticky-editing-and-resizing-in-executions-view

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@alexgrozav alexgrozav self-assigned this Sep 5, 2024
@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Sep 5, 2024
Copy link

cypress bot commented Sep 5, 2024

n8n    Run #6753

Run Properties:  status check passed Passed #6753  •  git commit c05f73f1f1: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 alexgrozav 🗃️ e2e/*
Project n8n
Branch Review n8n-7679-disable-sticky-editing-and-resizing-in-executions-view
Run status status check passed Passed #6753
Run duration 04m 51s
Commit git commit c05f73f1f1: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 alexgrozav 🗃️ e2e/*
Committer Alex Grozav
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 424
View all changes introduced in this branch ↗︎

Copy link
Contributor

github-actions bot commented Sep 5, 2024

✅ All Cypress E2E specs passed

@alexgrozav alexgrozav merged commit c5bc8e6 into master Sep 5, 2024
32 checks passed
@alexgrozav alexgrozav deleted the n8n-7679-disable-sticky-editing-and-resizing-in-executions-view branch September 5, 2024 11:18
@github-actions github-actions bot mentioned this pull request Sep 11, 2024
@Joffcom
Copy link
Member

Joffcom commented Sep 11, 2024

Got released with [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants