fix(core): Allow license:clear command to be used for licenses that failed renewal #10665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
tomi
reviewed
Sep 4, 2024
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <[email protected]>
n8n-assistant
bot
added
core
n8n
|
||||||||||||||||||||||||||||
| Project |
n8n
|
| Branch Review |
fix-license-clear-cmd
|
| Run status |
|
| Run duration | 04m 50s |
| Commit |
|
| Committer | Cornelius Suermann |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
424
|
| View all changes introduced in this branch ↗︎ | |
|
✅ All Cypress E2E specs passed |
Merged
|
Got released with |
riascho
pushed a commit
that referenced
this pull request
Sep 23, 2024
…ailed renewal (#10665) Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
license:clearcommand attempts to renew the license before deleting the license information from the database to free up any floating entitlements. However, if the renewal fails (e.g., due to a device fingerprint mismatch), the command errors out before the database record is deleted. This PR addresses the issue by handling errors from the renewal attempt without interrupting the deletion process.