fix(core): Flush responses for ai streaming endpoints #10633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8n-assistant
bot
added
core
netroy
force-pushed
the
flush-streaming-ai-responses
branch
2 times, most recently
from
c6cd76f to
b1b27c7
Compare
MiloradFilipovic
previously approved these changes
Sep 2, 2024
There was a problem hiding this comment.
I can confirm that this works as expected but would like for somebody in the back-end team to take a look also.
A bit more context: This is a fix that enables AI Assistant intermediate steps streaming in Firefox (was working in Chrome without this).
You should be seeing something like this:
https://github.com/user-attachments/assets/324cbfa7-aa14-45bb-aedc-3a700fa1d5fd
In order to test in UI:
- Run n8n locally from this branch (ai-assistant-improvements)
- Start AI Assistant chat from any non-code node
n8n
|
||||||||||||||||||||||||||||
| Project |
n8n
|
| Branch Review |
flush-streaming-ai-responses
|
| Run status |
|
| Run duration | 04m 44s |
| Commit |
|
| Committer | कारतोफ्फेलस्क्रिप्ट™ |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
422
|
| View all changes introduced in this branch ↗︎ | |
|
✅ All Cypress E2E specs passed |
netroy
force-pushed
the
flush-streaming-ai-responses
branch
from
b1b27c7 to
61a2980
Compare
|
✅ All Cypress E2E specs passed |
MiloradFilipovic
added a commit
that referenced
this pull request
Sep 2, 2024
* master: fix(core): Flush responses for ai streaming endpoints (#10633) fix: Re-enable infra provisioning and teardown (no-changelog) (#10636) feat(core): Execution curation (#10342) fix(Webhook Node): Add tests for utils (no-changelog) (#10613) fix: Fixes to cloud benchmarks (no-changelog) (#10634) test: Add JS CodeNode benchmark scenario (#10632) refactor(editor): Migrate `MainSidebar.vue` to composition API (no-changelog) (#10538) build: Fix `cli` nodemon config (#10628) docs: Add 'benchmark' scope to PR Title Conventions documentation (#10624) ci: Fixes to benchmarks in cloud (#10626) test(editor): Increase test coverage for users settings page and modal (#10623) fix(Wait Node): Append n8n attribution option (#10585) refactor(editor): Migrate `NodeSettings.vue` to composition API (#10545) fix(editor): Add pinned data only to manual executions in execution view (#10605) ci: Omit benchmark scope commits from changelog (no-changelog) (#10618) fix: Disable errors obfuscation (no-changelog) (#10617) ci: Fix script name in gh workflow (#10619) ci: Fix nightly image not being pushed to ghcr (#10620)
Merged
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When an endpoint in our current setup wants to stream responses, it needs to call
res.flush()after every chunk is written.In the long run we should probably move this check into
ControllerRegistry, and check that if a controller method returns aReadableStream, then we automatically setup streaming. But that requires a bit more refactor that is beyond the scope of this PR.Review / Merge checklist