fix(editor): Prevent Safari users from accessing the frontend over insecure contexts #10510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8n-assistant
bot
added
n8n team
MiloradFilipovic
approved these changes
Aug 22, 2024
| @@ -44,6 +44,7 @@ | |||
| "@vueuse/components": "^10.11.0", | |||
| "@vueuse/core": "^10.11.0", | |||
| "axios": "catalog:", | |||
| "bowser": "2.11.0", | |||
There was a problem hiding this comment.
Could we implement this without adding additional dependency just to detect Safari?
There was a problem hiding this comment.
- This is already a transitive dependency (check the lockfile changes)
- This adds about 5KB to the bundle before any tree-shaking
|
Test summaryRun details
Flakiness
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud |
||||||||||||||||||||||||||
|
✅ All Cypress E2E specs passed |
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Safari currently does not allow using secure cookies on localhost. This prevents anyone running n8n locally without https from accessing the frontend since all they ever see is the login screen, despite trying to logging-in multiple times.
Since the application cannot function this way, this PR updates the secure-cookie frontend check to also include a check for safari now.
Related Linear tickets, Github issues, and Community forum posts
ADO-2400
Review / Merge checklist