Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(n8n Google My Business Node): New node #10504

Merged
merged 44 commits into from
Oct 16, 2024

Conversation

valentina98
Copy link
Contributor

@valentina98 valentina98 commented Aug 21, 2024

Summary

Adds Google My Business node and trigger node

Related Linear tickets, Github issues, and Community forum posts

https://linear.app/n8n/issue/NODE-1614/community-pr-wip-add-google-my-business-node

https://community.n8n.io/t/google-my-business-node-request/8248/10

@n8n-assistant n8n-assistant bot added community Authored by a community member node/new Creation of an entirely new node in linear Issue or PR has been created in Linear for internal review labels Aug 21, 2024
@Joffcom
Copy link
Member

Joffcom commented Aug 21, 2024

Hey @valentina98,

Thanks for the PR, We have created "GHC-178" as the internal reference to get this reviewed.

One of us will be in touch if there are any changes needed, in most cases this is normally within a couple of weeks but it depends on the current workload of the team.

@valentina98 valentina98 changed the title WIP: Add Google My Business Node WIP: feat(n8n Google My Business Node): New node Aug 21, 2024
@valentina98 valentina98 changed the title WIP: feat(n8n Google My Business Node): New node feat(n8n Google My Business Node): New node Sep 27, 2024
Copy link
Contributor

@ShireenMissi ShireenMissi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ @valentina98 for the PR 🙏
the code is easy to read and very organised 👍
left some small refactoring comments apart from that looks good 🎉

Copy link
Contributor

@ShireenMissi ShireenMissi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@ShireenMissi ShireenMissi merged commit bf28fbe into n8n-io:master Oct 16, 2024
16 checks passed
@github-actions github-actions bot mentioned this pull request Oct 24, 2024
@janober
Copy link
Member

janober commented Oct 24, 2024

Got released with [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Authored by a community member in linear Issue or PR has been created in Linear for internal review node/new Creation of an entirely new node Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants