Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): Webhook and form baseUrl missing #10290

Merged
merged 1 commit into from
Aug 5, 2024

Conversation

michael-radency
Copy link
Contributor

Summary

PR fixes bug
image
image

Review / Merge checklist

#10268

@michael-radency michael-radency requested a review from ivov August 5, 2024 07:32
Copy link
Contributor

@ivov ivov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for catching this 🙏🏻

@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Aug 5, 2024
Copy link

cypress bot commented Aug 5, 2024



Test summary

25 1 0 0Flakiness 0


Run details

Project n8n
Status Failed
Commit f1cd557
Started Aug 5, 2024 8:59 AM
Ended Aug 5, 2024 9:05 AM
Duration 05:15 💡
OS Linux Debian -
Browser Electron 118

View run in Cypress Cloud ➡️


Failures

e2e/7-workflow-actions.cy.ts Failed
1 Workflow Actions > should not save workflow twice when save is in progress

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud

Copy link
Contributor

github-actions bot commented Aug 5, 2024

✅ All Cypress E2E specs passed

@michael-radency michael-radency merged commit 8131d66 into master Aug 5, 2024
27 checks passed
@michael-radency michael-radency deleted the fix-baseUrl-in-webhooks branch August 5, 2024 08:04
MiloradFilipovic added a commit that referenced this pull request Aug 5, 2024
* master:
  feat(editor): Auto-add LLM chain for new LLM nodes on empty canvas (#10245)
  fix(core): Fix user telemetry bugs (#10293)
  refactor(core): Remove stray log from telemetry event relay (no-changelog) (#10295)
  refactor(core): Decouple user events from internal hooks (no-changelog) (#10292)
  feat(core): Support community packages in scaling-mode  (#10228)
  test(core): Move unit tests closer to testable components (no-changelog) (#10287)
  fix(core): Webhook and form baseUrl missing (#10290)
  refactor(core): Port cache config (no-changelog) (#10286)
@github-actions github-actions bot mentioned this pull request Aug 7, 2024
@janober
Copy link
Member

janober commented Aug 7, 2024

Got released with [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants