feat(Okta Node): Add Okta Node #10278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8n-assistant
bot
added
n8n team
ShireenMissi
force-pushed
the
node-1478-okta-node
branch
2 times, most recently
from
99e7c8f to
7cc5cee
Compare
ShireenMissi
force-pushed
the
node-1478-okta-node
branch
from
7cc5cee to
43971c2
Compare
Joffcom
requested changes
Aug 5, 2024
There was a problem hiding this comment.
in general LGTM
We can improve credentials in this PR
- add descriptions to parameters
- tolerate missing
https:// - remove SSWS from Access Token field name and add description (Secure Session Web Service)
Errors have useful information in errorData we could add post request function to extract more descriptive message/description from there
ShireenMissi
force-pushed
the
node-1478-okta-node
branch
from
89d316d to
42443bc
Compare
Joffcom
approved these changes
Aug 12, 2024
|
Test summaryRun details
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud |
|
✅ All Cypress E2E specs passed |
Merged
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR Adds a new node for Okta with the following operations for users:
Related Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/NODE-1478/okta-node
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)