From d5dcbbf8e5e0f0d86691f8c03bceb426e0c23963 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Iv=C3=A1n=20Ovejero?= <ivov.src@gmail.com>
Date: Tue, 9 Jan 2024 16:37:05 +0100
Subject: [PATCH] ci: Fix lint setup in `chat` package (no-changelog) (#8275)

---
 packages/@n8n/chat/.eslintrc.cjs              | 41 -------------------
 packages/@n8n/chat/package.json               |  3 +-
 packages/@n8n/chat/src/App.vue                |  2 +-
 .../@n8n/chat/src/__stories__/App.stories.ts  |  2 +-
 packages/@n8n/chat/src/components/Chat.vue    |  2 +-
 .../@n8n/chat/src/components/ChatWindow.vue   |  4 +-
 packages/@n8n/chat/src/components/Input.vue   |  2 +-
 packages/@n8n/chat/src/components/Layout.vue  |  2 +-
 packages/@n8n/chat/src/components/Message.vue |  8 +---
 .../chat/src/components/MessageTyping.vue     |  4 +-
 packages/@n8n/chat/src/plugins/chat.ts        |  2 +-
 packages/@n8n/chat/src/types/chat.ts          |  2 +-
 packages/@n8n_io/eslint-config/frontend.js    |  6 ---
 packages/design-system/.eslintrc.js           |  2 -
 packages/editor-ui/.eslintrc.js               |  2 +
 15 files changed, 17 insertions(+), 67 deletions(-)

diff --git a/packages/@n8n/chat/.eslintrc.cjs b/packages/@n8n/chat/.eslintrc.cjs
index bf217e07f3153..a1ad467ea3b92 100644
--- a/packages/@n8n/chat/.eslintrc.cjs
+++ b/packages/@n8n/chat/.eslintrc.cjs
@@ -7,45 +7,4 @@ module.exports = {
 	extends: ['@n8n_io/eslint-config/frontend'],
 
 	...sharedOptions(__dirname, 'frontend'),
-
-	rules: {
-		'n8n-local-rules/dangerously-use-html-string-missing': 'off',
-
-		// TODO: Remove these
-		'id-denylist': 'warn',
-		'import/extensions': 'warn',
-		'import/no-default-export': 'warn',
-		'import/order': 'off',
-		'import/no-cycle': 'warn',
-		'import/no-duplicates': 'warn',
-		'@typescript-eslint/ban-types': 'warn',
-		'@typescript-eslint/dot-notation': 'warn',
-		'@typescript-eslint/lines-between-class-members': 'warn',
-		'@typescript-eslint/member-delimiter-style': 'warn',
-		'@typescript-eslint/naming-convention': 'warn',
-		'@typescript-eslint/no-empty-interface': 'warn',
-		'@typescript-eslint/no-for-in-array': 'warn',
-		'@typescript-eslint/no-loop-func': 'warn',
-		'@typescript-eslint/no-non-null-assertion': 'warn',
-		'@typescript-eslint/no-shadow': 'warn',
-		'@typescript-eslint/no-this-alias': 'warn',
-		'@typescript-eslint/no-unnecessary-boolean-literal-compare': 'warn',
-		'@typescript-eslint/no-unnecessary-type-assertion': 'warn',
-		'@typescript-eslint/no-unsafe-argument': 'warn',
-		'@typescript-eslint/no-unsafe-call': 'warn',
-		'@typescript-eslint/no-unsafe-return': 'warn',
-		'@typescript-eslint/no-unused-expressions': 'warn',
-		'@typescript-eslint/no-unused-vars': 'warn',
-		'@typescript-eslint/no-use-before-define': 'warn',
-		'@typescript-eslint/no-var-requires': 'warn',
-		'@typescript-eslint/prefer-nullish-coalescing': 'warn',
-		'@typescript-eslint/prefer-optional-chain': 'warn',
-		'@typescript-eslint/restrict-plus-operands': 'warn',
-		'@typescript-eslint/unbound-method': 'warn',
-		'@typescript-eslint/ban-ts-comment': ['warn', { 'ts-ignore': true }],
-		'@typescript-eslint/no-redundant-type-constituents': 'warn',
-		'@typescript-eslint/no-base-to-string': 'warn',
-		'@typescript-eslint/no-explicit-any': 'warn',
-		'@typescript-eslint/no-unsafe-enum-comparison': 'warn',
-	},
 };
diff --git a/packages/@n8n/chat/package.json b/packages/@n8n/chat/package.json
index 9408ae572d52b..5700b3273e613 100644
--- a/packages/@n8n/chat/package.json
+++ b/packages/@n8n/chat/package.json
@@ -14,7 +14,8 @@
     "test:dev": "vitest",
     "test": "vitest run --coverage",
     "type-check": "vue-tsc --noEmit -p tsconfig.json --composite false",
-    "lint": "eslint . --ext .vue,.js,.jsx,.cjs,.mjs,.ts,.tsx,.cts,.mts --fix --ignore-path .gitignore --ignore-path .eslintignore",
+    "lint": "eslint . --ext .js,.ts,.vue --quiet",
+    "lintfix": "eslint . --ext .js,.ts,.vue --fix",
     "format": "prettier --write src/",
     "storybook": "storybook dev -p 6006 --no-open",
     "build:storybook": "storybook build",
diff --git a/packages/@n8n/chat/src/App.vue b/packages/@n8n/chat/src/App.vue
index d2afb274cdb65..ec90bef42583e 100644
--- a/packages/@n8n/chat/src/App.vue
+++ b/packages/@n8n/chat/src/App.vue
@@ -1,9 +1,9 @@
 <script lang="ts" setup>
-import { Chat, ChatWindow } from '@n8n/chat/components';
 import { computed, onMounted } from 'vue';
 import hljs from 'highlight.js/lib/core';
 import hljsXML from 'highlight.js/lib/languages/xml';
 import hljsJavascript from 'highlight.js/lib/languages/javascript';
+import { Chat, ChatWindow } from '@n8n/chat/components';
 import { useOptions } from '@n8n/chat/composables';
 
 defineProps({});
diff --git a/packages/@n8n/chat/src/__stories__/App.stories.ts b/packages/@n8n/chat/src/__stories__/App.stories.ts
index 1ff4f0c6872ae..ca93cdb240d1c 100644
--- a/packages/@n8n/chat/src/__stories__/App.stories.ts
+++ b/packages/@n8n/chat/src/__stories__/App.stories.ts
@@ -1,8 +1,8 @@
 /* eslint-disable @typescript-eslint/naming-convention */
 import type { StoryObj } from '@storybook/vue3';
+import { onMounted } from 'vue';
 import type { ChatOptions } from '@n8n/chat/types';
 import { createChat } from '@n8n/chat/index';
-import { onMounted } from 'vue';
 
 const webhookUrl = 'http://localhost:5678/webhook/f406671e-c954-4691-b39a-66c90aa2f103/chat';
 
diff --git a/packages/@n8n/chat/src/components/Chat.vue b/packages/@n8n/chat/src/components/Chat.vue
index e9f44d646bd4e..e9a4476a98d79 100644
--- a/packages/@n8n/chat/src/components/Chat.vue
+++ b/packages/@n8n/chat/src/components/Chat.vue
@@ -1,10 +1,10 @@
 <script setup lang="ts">
+import { nextTick, onMounted } from 'vue';
 import Layout from '@n8n/chat/components/Layout.vue';
 import GetStarted from '@n8n/chat/components/GetStarted.vue';
 import GetStartedFooter from '@n8n/chat/components/GetStartedFooter.vue';
 import MessagesList from '@n8n/chat/components/MessagesList.vue';
 import Input from '@n8n/chat/components/Input.vue';
-import { nextTick, onMounted } from 'vue';
 import { useI18n, useChat, useOptions } from '@n8n/chat/composables';
 import { chatEventBus } from '@n8n/chat/event-buses';
 
diff --git a/packages/@n8n/chat/src/components/ChatWindow.vue b/packages/@n8n/chat/src/components/ChatWindow.vue
index 16608f7e4b9f3..1d1f7ae3c22f2 100644
--- a/packages/@n8n/chat/src/components/ChatWindow.vue
+++ b/packages/@n8n/chat/src/components/ChatWindow.vue
@@ -3,8 +3,8 @@
 import IconChat from 'virtual:icons/mdi/chat';
 // eslint-disable-next-line import/no-unresolved
 import IconChevronDown from 'virtual:icons/mdi/chevron-down';
-import Chat from '@n8n/chat/components/Chat.vue';
 import { nextTick, ref } from 'vue';
+import Chat from '@n8n/chat/components/Chat.vue';
 import { chatEventBus } from '@n8n/chat/event-buses';
 
 const isOpen = ref(false);
@@ -23,7 +23,7 @@ function toggle() {
 <template>
 	<div class="chat-window-wrapper">
 		<Transition name="chat-window-transition">
-			<div class="chat-window" v-show="isOpen">
+			<div v-show="isOpen" class="chat-window">
 				<Chat />
 			</div>
 		</Transition>
diff --git a/packages/@n8n/chat/src/components/Input.vue b/packages/@n8n/chat/src/components/Input.vue
index 068e47e318014..68b9deeb2497d 100644
--- a/packages/@n8n/chat/src/components/Input.vue
+++ b/packages/@n8n/chat/src/components/Input.vue
@@ -1,8 +1,8 @@
 <script setup lang="ts">
 // eslint-disable-next-line import/no-unresolved
 import IconSend from 'virtual:icons/mdi/send';
-import { useI18n, useChat } from '@n8n/chat/composables';
 import { computed, ref } from 'vue';
+import { useI18n, useChat } from '@n8n/chat/composables';
 
 const chatStore = useChat();
 const { waitingForResponse } = chatStore;
diff --git a/packages/@n8n/chat/src/components/Layout.vue b/packages/@n8n/chat/src/components/Layout.vue
index b3a2e89b832d7..c61ec544771f2 100644
--- a/packages/@n8n/chat/src/components/Layout.vue
+++ b/packages/@n8n/chat/src/components/Layout.vue
@@ -26,7 +26,7 @@ onBeforeUnmount(() => {
 		<div v-if="$slots.header" class="chat-header">
 			<slot name="header" />
 		</div>
-		<div v-if="$slots.default" class="chat-body" ref="chatBodyRef">
+		<div v-if="$slots.default" ref="chatBodyRef" class="chat-body">
 			<slot />
 		</div>
 		<div v-if="$slots.footer" class="chat-footer">
diff --git a/packages/@n8n/chat/src/components/Message.vue b/packages/@n8n/chat/src/components/Message.vue
index 84c9013441c4a..6110315102d71 100644
--- a/packages/@n8n/chat/src/components/Message.vue
+++ b/packages/@n8n/chat/src/components/Message.vue
@@ -1,10 +1,10 @@
 <script lang="ts" setup>
 /* eslint-disable @typescript-eslint/naming-convention */
-import type { ChatMessage } from '@n8n/chat/types';
 import type { PropType } from 'vue';
 import { computed, toRefs } from 'vue';
 import VueMarkdown from 'vue-markdown-render';
 import hljs from 'highlight.js/lib/core';
+import type { ChatMessage } from '@n8n/chat/types';
 
 const props = defineProps({
 	message: {
@@ -41,11 +41,7 @@ const markdownOptions = {
 <template>
 	<div class="chat-message" :class="classes">
 		<slot>
-			<vue-markdown
-				class="chat-message-markdown"
-				:source="messageText"
-				:options="markdownOptions"
-			/>
+			<VueMarkdown class="chat-message-markdown" :source="messageText" :options="markdownOptions" />
 		</slot>
 	</div>
 </template>
diff --git a/packages/@n8n/chat/src/components/MessageTyping.vue b/packages/@n8n/chat/src/components/MessageTyping.vue
index c7f6cbb16cdae..cf5981a97c6ef 100644
--- a/packages/@n8n/chat/src/components/MessageTyping.vue
+++ b/packages/@n8n/chat/src/components/MessageTyping.vue
@@ -1,8 +1,8 @@
 <script lang="ts" setup>
-import type { ChatMessage } from '@n8n/chat/types';
-import { Message } from './index';
 import type { PropType } from 'vue';
 import { computed } from 'vue';
+import { Message } from './index';
+import type { ChatMessage } from '@n8n/chat/types';
 
 const props = defineProps({
 	animation: {
diff --git a/packages/@n8n/chat/src/plugins/chat.ts b/packages/@n8n/chat/src/plugins/chat.ts
index ec0adffe41782..80b343ac4554e 100644
--- a/packages/@n8n/chat/src/plugins/chat.ts
+++ b/packages/@n8n/chat/src/plugins/chat.ts
@@ -1,7 +1,7 @@
 import type { Plugin } from 'vue';
 import { computed, nextTick, ref } from 'vue';
-import type { ChatMessage, ChatOptions } from '@n8n/chat/types';
 import { v4 as uuidv4 } from 'uuid';
+import type { ChatMessage, ChatOptions } from '@n8n/chat/types';
 import { chatEventBus } from '@n8n/chat/event-buses';
 import * as api from '@n8n/chat/api';
 import { ChatOptionsSymbol, ChatSymbol, localStorageSessionIdKey } from '@n8n/chat/constants';
diff --git a/packages/@n8n/chat/src/types/chat.ts b/packages/@n8n/chat/src/types/chat.ts
index fe6e4647a5bed..07c8c253cbf2f 100644
--- a/packages/@n8n/chat/src/types/chat.ts
+++ b/packages/@n8n/chat/src/types/chat.ts
@@ -1,5 +1,5 @@
-import type { ChatMessage } from '@n8n/chat/types/messages';
 import type { Ref } from 'vue';
+import type { ChatMessage } from '@n8n/chat/types/messages';
 
 export interface Chat {
 	initialMessages: Ref<ChatMessage[]>;
diff --git a/packages/@n8n_io/eslint-config/frontend.js b/packages/@n8n_io/eslint-config/frontend.js
index c31d32b036b0c..6cecb84746eb5 100644
--- a/packages/@n8n_io/eslint-config/frontend.js
+++ b/packages/@n8n_io/eslint-config/frontend.js
@@ -15,12 +15,6 @@ module.exports = {
 	ignorePatterns: ['**/*.js', '**/*.d.ts', 'vite.config.ts', '**/*.ts.snap'],
 
 	overrides: [
-		{
-			files: ['src/**/*.vue'],
-			rules: {
-				'n8n-local-rules/dangerously-use-html-string-missing': 'error',
-			},
-		},
 		{
 			files: ['**/*.test.ts', '**/test/**/*.ts', '**/__tests__/**/*.ts'],
 			rules: {
diff --git a/packages/design-system/.eslintrc.js b/packages/design-system/.eslintrc.js
index a14832cc551a3..3fc314bc4259d 100644
--- a/packages/design-system/.eslintrc.js
+++ b/packages/design-system/.eslintrc.js
@@ -9,8 +9,6 @@ module.exports = {
 	...sharedOptions(__dirname, 'frontend'),
 
 	rules: {
-		'n8n-local-rules/dangerously-use-html-string-missing': 'off',
-
 		// TODO: Remove these
 		'import/no-default-export': 'warn',
 		'import/order': 'off',
diff --git a/packages/editor-ui/.eslintrc.js b/packages/editor-ui/.eslintrc.js
index 17e32ae9d6510..671046a0cb539 100644
--- a/packages/editor-ui/.eslintrc.js
+++ b/packages/editor-ui/.eslintrc.js
@@ -9,6 +9,8 @@ module.exports = {
 	...sharedOptions(__dirname, 'frontend'),
 
 	rules: {
+		'n8n-local-rules/dangerously-use-html-string-missing': 'error',
+
 		// TODO: Remove these
 		'id-denylist': 'warn',
 		'import/extensions': 'warn',