From b70b42db37246df40336ace08ab99e34e59913dc Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E0=A4=95=E0=A4=BE=E0=A4=B0=E0=A4=A4=E0=A5=8B=E0=A4=AB?= =?UTF-8?q?=E0=A5=8D=E0=A4=AB=E0=A5=87=E0=A4=B2=E0=A4=B8=E0=A5=8D=E0=A4=95?= =?UTF-8?q?=E0=A5=8D=E0=A4=B0=E0=A4=BF=E0=A4=AA=E0=A5=8D=E0=A4=9F=E2=84=A2?= Date: Wed, 14 Feb 2024 15:35:42 +0100 Subject: [PATCH] fix(core): Improve the startup error when EXECUTIONS_PROCESS is set (#8630) Co-authored-by: Omar Ajoue --- packages/cli/src/commands/BaseCommand.ts | 5 ----- packages/cli/src/config/index.ts | 21 ++++++++++++++++++--- packages/cli/src/config/schema.ts | 7 +++---- 3 files changed, 21 insertions(+), 12 deletions(-) diff --git a/packages/cli/src/commands/BaseCommand.ts b/packages/cli/src/commands/BaseCommand.ts index 5cd5b0cbbfe02..faa5db165df43 100644 --- a/packages/cli/src/commands/BaseCommand.ts +++ b/packages/cli/src/commands/BaseCommand.ts @@ -83,11 +83,6 @@ export abstract class BaseCommand extends Command { 'Support for MySQL/MariaDB has been deprecated and will be removed with an upcoming version of n8n. Please migrate to PostgreSQL.', ); } - if (process.env.EXECUTIONS_PROCESS === 'own') { - throw new ApplicationError( - 'Own mode has been removed. If you need the isolation and performance gains, please consider using queue mode.', - ); - } if (process.env.N8N_SKIP_WEBHOOK_DEREGISTRATION_SHUTDOWN) { this.logger.warn( diff --git a/packages/cli/src/config/index.ts b/packages/cli/src/config/index.ts index 6a83f7e6d57f1..755d1105828df 100644 --- a/packages/cli/src/config/index.ts +++ b/packages/cli/src/config/index.ts @@ -73,10 +73,25 @@ if (userManagement.jwtRefreshTimeoutHours >= userManagement.jwtSessionDurationHo config.set('userManagement.jwtRefreshTimeoutHours', 0); } -if (config.getEnv('executions.process') !== 'IGNORED') { - throw new ApplicationError( - 'Own mode has been removed. If you need the isolation and performance gains, please consider using queue mode.', + +import colors from 'picocolors'; +const executionProcess = config.getEnv('executions.process'); +if (executionProcess) { + console.error( + colors.yellow('Please unset the deprecated env variable'), + colors.bold(colors.yellow('EXECUTIONS_PROCESS')), + ); +} +if (executionProcess === 'own') { + console.error( + colors.bold(colors.red('Application failed to start because "Own" mode has been removed.')), + ); + console.error( + colors.red( + 'If you need the isolation and performance gains, please consider using queue mode instead.\n\n', + ), ); + process.exit(-1); } setGlobalState({ diff --git a/packages/cli/src/config/schema.ts b/packages/cli/src/config/schema.ts index c4c1566b03016..0fde528a9877b 100644 --- a/packages/cli/src/config/schema.ts +++ b/packages/cli/src/config/schema.ts @@ -234,12 +234,11 @@ export const schema = { }, executions: { - // By default workflows get always executed in the main process. // TODO: remove this and all usage of `executions.process` when we're sure that nobody has this in their config file anymore. process: { - doc: 'Own mode has been removed and is only here for backwards compatibility of config files. N8n will use main mode for executions unless `executions.mode` is set to `queue`.', - format: ['main', 'own', 'IGNORED'] as const, - default: 'IGNORED', + doc: 'Deprecated key, that will be removed in the future. Please remove it from your configuration and environment variables to prevent issues in the future.', + format: String, + default: '', env: 'EXECUTIONS_PROCESS', }, mode: {