From 8d3aeb2421af641f0ab45fd4d137fdab7e1dfd10 Mon Sep 17 00:00:00 2001 From: Alex Grozav Date: Mon, 15 May 2023 17:58:54 +0300 Subject: [PATCH] fix: add void on non-await async calls --- .../CredentialEdit/CredentialEdit.vue | 3 +- .../src/components/ExecutionsList.vue | 2 +- .../ExecutionsView/ExecutionsList.vue | 2 +- .../src/components/ExpressionEdit.vue | 4 +- .../editor-ui/src/components/MainSidebar.vue | 6 +- .../src/components/NodeDetailsView.vue | 2 +- .../src/components/NodeSettingsTabs.vue | 2 +- .../src/components/ParameterInput.vue | 8 +-- packages/editor-ui/src/components/RunData.vue | 6 +- .../src/components/WorkflowSettings.vue | 10 +++- .../editor-ui/src/mixins/pushConnection.ts | 4 +- .../editor-ui/src/mixins/workflowActivate.ts | 4 +- .../editor-ui/src/mixins/workflowHelpers.ts | 4 +- packages/editor-ui/src/mixins/workflowRun.ts | 2 +- packages/editor-ui/src/views/NodeView.vue | 60 +++++++++---------- 15 files changed, 61 insertions(+), 58 deletions(-) diff --git a/packages/editor-ui/src/components/CredentialEdit/CredentialEdit.vue b/packages/editor-ui/src/components/CredentialEdit/CredentialEdit.vue index 353acbc164517..06054b323244c 100644 --- a/packages/editor-ui/src/components/CredentialEdit/CredentialEdit.vue +++ b/packages/editor-ui/src/components/CredentialEdit/CredentialEdit.vue @@ -160,12 +160,13 @@ import { updateNodeAuthType, isCredentialModalState, } from '@/utils'; +import { externalHooks } from '@/mixins/externalHooks'; interface NodeAccessMap { [nodeType: string]: ICredentialNodeAccess | null; } -export default mixins(nodeHelpers).extend({ +export default mixins(nodeHelpers, externalHooks).extend({ name: 'CredentialEdit', components: { CredentialSharing, diff --git a/packages/editor-ui/src/components/ExecutionsList.vue b/packages/editor-ui/src/components/ExecutionsList.vue index 07bc2b316450a..810e84f66795b 100644 --- a/packages/editor-ui/src/components/ExecutionsList.vue +++ b/packages/editor-ui/src/components/ExecutionsList.vue @@ -350,7 +350,7 @@ export default mixins(externalHooks, genericHelpers, executionHelpers).extend({ await this.loadWorkflows(); this.handleAutoRefreshToggle(); - this.$externalHooks().run('executionsList.openDialog'); + void this.$externalHooks().run('executionsList.openDialog'); this.$telemetry.track('User opened Executions log', { workflow_id: this.workflowsStore.workflowId, }); diff --git a/packages/editor-ui/src/components/ExecutionsView/ExecutionsList.vue b/packages/editor-ui/src/components/ExecutionsView/ExecutionsList.vue index d1b5b9ca39ffd..fd90019ca9bbe 100644 --- a/packages/editor-ui/src/components/ExecutionsView/ExecutionsList.vue +++ b/packages/editor-ui/src/components/ExecutionsView/ExecutionsList.vue @@ -529,7 +529,7 @@ export default mixins(executionHelpers, debounceHelper, workflowHelpers).extend( this.tagsStore.upsertTags(tags); - this.$externalHooks().run('workflow.open', { workflowId, workflowName: data.name }); + void this.$externalHooks().run('workflow.open', { workflowId, workflowName: data.name }); this.uiStore.stateIsDirty = false; }, async addNodes(nodes: INodeUi[], connections?: IConnections) { diff --git a/packages/editor-ui/src/components/ExpressionEdit.vue b/packages/editor-ui/src/components/ExpressionEdit.vue index 3b1e308aa5b0c..db23d82aa3b60 100644 --- a/packages/editor-ui/src/components/ExpressionEdit.vue +++ b/packages/editor-ui/src/components/ExpressionEdit.vue @@ -143,7 +143,7 @@ export default mixins(externalHooks, genericHelpers, debounceHelper).extend({ itemSelected(eventData: IVariableItemSelected) { // eslint-disable-next-line @typescript-eslint/no-explicit-any (this.$refs.inputFieldExpression as any).itemSelected(eventData); - this.$externalHooks().run('expressionEdit.itemSelected', { + void this.$externalHooks().run('expressionEdit.itemSelected', { parameter: this.parameter, value: this.value, selectedItem: eventData, @@ -222,7 +222,7 @@ export default mixins(externalHooks, genericHelpers, debounceHelper).extend({ // eslint-disable-next-line @typescript-eslint/no-explicit-any (this.$refs.expressionResult && (this.$refs.expressionResult as any).getValue()) || undefined; - this.$externalHooks().run('expressionEdit.dialogVisibleChanged', { + void this.$externalHooks().run('expressionEdit.dialogVisibleChanged', { dialogVisible: newValue, parameter: this.parameter, value: this.value, diff --git a/packages/editor-ui/src/components/MainSidebar.vue b/packages/editor-ui/src/components/MainSidebar.vue index 778112d4a5947..cc8ccb4f5644c 100644 --- a/packages/editor-ui/src/components/MainSidebar.vue +++ b/packages/editor-ui/src/components/MainSidebar.vue @@ -113,7 +113,6 @@ import type { IExecutionResponse, IMenuItem, IVersion } from '@/Interface'; import type { MessageBoxInputData } from 'element-ui/types/message-box'; import GiftNotificationIcon from './GiftNotificationIcon.vue'; -import WorkflowSettings from '@/components/WorkflowSettings.vue'; import { genericHelpers } from '@/mixins/genericHelpers'; import { useMessage } from '@/composables'; @@ -138,7 +137,6 @@ export default defineComponent({ name: 'MainSidebar', components: { GiftNotificationIcon, - WorkflowSettings, }, mixins: [genericHelpers, workflowHelpers, workflowRun, userHelpers, debounceHelper], setup(props) { @@ -329,7 +327,7 @@ export default defineComponent({ async mounted() { this.basePath = this.rootStore.baseUrl; if (this.$refs.user) { - this.$externalHooks().run('mainSidebar.mounted', { userRef: this.$refs.user }); + void this.$externalHooks().run('mainSidebar.mounted', { userRef: this.$refs.user }); } if (window.innerWidth < 900 || this.uiStore.isNodeView) { this.uiStore.sidebarMenuCollapsed = true; @@ -467,7 +465,7 @@ export default defineComponent({ return defaultSettingsRoute; }, onResize(event: UIEvent) { - this.callDebounced('onResizeEnd', { debounceTime: 100 }, event); + void this.callDebounced('onResizeEnd', { debounceTime: 100 }, event); }, onResizeEnd(event: UIEvent) { const browserWidth = (event.target as Window).outerWidth; diff --git a/packages/editor-ui/src/components/NodeDetailsView.vue b/packages/editor-ui/src/components/NodeDetailsView.vue index de12317ee4259..fd42ef0215fbc 100644 --- a/packages/editor-ui/src/components/NodeDetailsView.vue +++ b/packages/editor-ui/src/components/NodeDetailsView.vue @@ -419,7 +419,7 @@ export default defineComponent({ this.avgInputRowHeight = 0; setTimeout(this.ndvStore.setNDVSessionId, 0); - this.$externalHooks().run('dataDisplay.nodeTypeChanged', { + void this.$externalHooks().run('dataDisplay.nodeTypeChanged', { nodeSubtitle: this.getNodeSubtitle(node, this.activeNodeType, this.getCurrentWorkflow()), }); diff --git a/packages/editor-ui/src/components/NodeSettingsTabs.vue b/packages/editor-ui/src/components/NodeSettingsTabs.vue index 06fa969ffcaff..c8328814ea53e 100644 --- a/packages/editor-ui/src/components/NodeSettingsTabs.vue +++ b/packages/editor-ui/src/components/NodeSettingsTabs.vue @@ -115,7 +115,7 @@ export default mixins(externalHooks).extend({ methods: { onTabSelect(tab: string) { if (tab === 'docs' && this.nodeType) { - this.$externalHooks().run('dataDisplay.onDocumentationUrlClick', { + void this.$externalHooks().run('dataDisplay.onDocumentationUrlClick', { nodeType: this.nodeType as INodeTypeDescription, documentationUrl: this.documentationUrl, }); diff --git a/packages/editor-ui/src/components/ParameterInput.vue b/packages/editor-ui/src/components/ParameterInput.vue index efeef45bf4ba2..e79b3725cbacb 100644 --- a/packages/editor-ui/src/components/ParameterInput.vue +++ b/packages/editor-ui/src/components/ParameterInput.vue @@ -829,7 +829,7 @@ export default mixins(externalHooks, nodeHelpers, workflowHelpers, debounceHelpe this.updateNodeCredentialIssues(node); } - this.$externalHooks().run('nodeSettings.credentialSelected', { updateInformation }); + void this.$externalHooks().run('nodeSettings.credentialSelected', { updateInformation }); }, /** * Check whether a param value must be skipped when collecting node param issues for validation. @@ -1125,7 +1125,7 @@ export default mixins(externalHooks, nodeHelpers, workflowHelpers, debounceHelpe had_parameter: typeof prevValue === 'string' && prevValue.includes('$parameter'), }; this.$telemetry.track('User switched parameter mode', telemetryPayload); - this.$externalHooks().run('parameterInput.modeSwitch', telemetryPayload); + void this.$externalHooks().run('parameterInput.modeSwitch', telemetryPayload); } }, }, @@ -1134,7 +1134,7 @@ export default mixins(externalHooks, nodeHelpers, workflowHelpers, debounceHelpe const remoteParameterOptions = this.$el.querySelectorAll('.remote-parameter-option'); if (remoteParameterOptions.length > 0) { - this.$externalHooks().run('parameterInput.updated', { remoteParameterOptions }); + void this.$externalHooks().run('parameterInput.updated', { remoteParameterOptions }); } }); }, @@ -1174,7 +1174,7 @@ export default mixins(externalHooks, nodeHelpers, workflowHelpers, debounceHelpe ); } - this.$externalHooks().run('parameterInput.mount', { + void this.$externalHooks().run('parameterInput.mount', { parameter: this.parameter, inputFieldRef: this.$refs['inputField'], }); diff --git a/packages/editor-ui/src/components/RunData.vue b/packages/editor-ui/src/components/RunData.vue index abbf42a265d07..6c58b09f1109f 100644 --- a/packages/editor-ui/src/components/RunData.vue +++ b/packages/editor-ui/src/components/RunData.vue @@ -1022,7 +1022,7 @@ export default mixins(externalHooks, genericHelpers, nodeHelpers, pinData).exten view: this.displayMode, run_index: this.runIndex, }; - this.$externalHooks().run('runData.onDataPinningSuccess', telemetryPayload); + void this.$externalHooks().run('runData.onDataPinningSuccess', telemetryPayload); this.$telemetry.track('Ndv data pinning success', telemetryPayload); }, onDataPinningError({ @@ -1055,7 +1055,7 @@ export default mixins(externalHooks, genericHelpers, nodeHelpers, pinData).exten view: !this.hasNodeRun && !this.hasPinData ? 'none' : this.displayMode, }; - this.$externalHooks().run('runData.onTogglePinData', telemetryPayload); + void this.$externalHooks().run('runData.onTogglePinData', telemetryPayload); this.$telemetry.track('User clicked pin data icon', telemetryPayload); } @@ -1164,7 +1164,7 @@ export default mixins(externalHooks, genericHelpers, nodeHelpers, pinData).exten } this.closeBinaryDataDisplay(); - this.$externalHooks().run('runData.displayModeChanged', { + void this.$externalHooks().run('runData.displayModeChanged', { newValue: displayMode, oldValue: previous, }); diff --git a/packages/editor-ui/src/components/WorkflowSettings.vue b/packages/editor-ui/src/components/WorkflowSettings.vue index 66aeb21028a2c..6f5cccd67c4bc 100644 --- a/packages/editor-ui/src/components/WorkflowSettings.vue +++ b/packages/editor-ui/src/components/WorkflowSettings.vue @@ -521,7 +521,9 @@ export default mixins(externalHooks, genericHelpers).extend({ this.timeoutHMS = this.convertToHMS(workflowSettings.executionTimeout); this.isLoading = false; - this.$externalHooks().run('workflowSettings.dialogVisibleChanged', { dialogVisible: true }); + void this.$externalHooks().run('workflowSettings.dialogVisibleChanged', { + dialogVisible: true, + }); this.$telemetry.track('User opened workflow settings', { workflow_id: this.workflowsStore.workflowId, }); @@ -534,7 +536,9 @@ export default mixins(externalHooks, genericHelpers).extend({ }, closeDialog() { this.modalBus.emit('close'); - this.$externalHooks().run('workflowSettings.dialogVisibleChanged', { dialogVisible: false }); + void this.$externalHooks().run('workflowSettings.dialogVisibleChanged', { + dialogVisible: false, + }); }, setTimeout(key: string, value: string) { const time = value ? parseInt(value, 10) : 0; @@ -825,7 +829,7 @@ export default mixins(externalHooks, genericHelpers).extend({ this.closeDialog(); - this.$externalHooks().run('workflowSettings.saveSettings', { oldSettings }); + void this.$externalHooks().run('workflowSettings.saveSettings', { oldSettings }); this.$telemetry.track('User updated workflow settings', { workflow_id: this.workflowsStore.workflowId, }); diff --git a/packages/editor-ui/src/mixins/pushConnection.ts b/packages/editor-ui/src/mixins/pushConnection.ts index e64957180f763..8c70aed0febeb 100644 --- a/packages/editor-ui/src/mixins/pushConnection.ts +++ b/packages/editor-ui/src/mixins/pushConnection.ts @@ -380,7 +380,7 @@ export const pushConnection = defineComponent({ ) { const error = runDataExecuted.data.resultData.error as ExpressionError; - this.getWorkflowDataToSave().then((workflowData) => { + void this.getWorkflowDataToSave().then((workflowData) => { const eventData: IDataObject = { caused_by_credential: false, error_message: error.description, @@ -511,7 +511,7 @@ export const pushConnection = defineComponent({ .length; } - this.$externalHooks().run('pushConnection.executionFinished', { + void this.$externalHooks().run('pushConnection.executionFinished', { itemsCount, nodeName: runDataExecuted.data.resultData.lastNodeExecuted, errorMessage: runDataExecutedErrorMessage, diff --git a/packages/editor-ui/src/mixins/workflowActivate.ts b/packages/editor-ui/src/mixins/workflowActivate.ts index 67b992eebefc2..bf01f747420da 100644 --- a/packages/editor-ui/src/mixins/workflowActivate.ts +++ b/packages/editor-ui/src/mixins/workflowActivate.ts @@ -62,7 +62,7 @@ export const workflowActivate = defineComponent({ ndv_input: telemetrySource === 'ndv', }; this.$telemetry.track('User set workflow active status', telemetryPayload); - this.$externalHooks().run('workflowActivate.updateWorkflowActivation', telemetryPayload); + void this.$externalHooks().run('workflowActivate.updateWorkflowActivation', telemetryPayload); try { if (isWorkflowActive && newActiveState) { @@ -106,7 +106,7 @@ export const workflowActivate = defineComponent({ const activationEventName = isCurrentWorkflow ? 'workflow.activeChangeCurrent' : 'workflow.activeChange'; - this.$externalHooks().run(activationEventName, { + void this.$externalHooks().run(activationEventName, { workflowId: currWorkflowId, active: newActiveState, }); diff --git a/packages/editor-ui/src/mixins/workflowHelpers.ts b/packages/editor-ui/src/mixins/workflowHelpers.ts index c730f7c59620b..147f17c5dc42f 100644 --- a/packages/editor-ui/src/mixins/workflowHelpers.ts +++ b/packages/editor-ui/src/mixins/workflowHelpers.ts @@ -732,7 +732,7 @@ export const workflowHelpers = defineComponent({ this.uiStore.stateIsDirty = false; this.uiStore.removeActiveAction('workflowSaving'); - this.$externalHooks().run('workflow.afterUpdate', { workflowData }); + void this.$externalHooks().run('workflow.afterUpdate', { workflowData }); return true; } catch (error) { @@ -896,7 +896,7 @@ export const workflowHelpers = defineComponent({ this.uiStore.removeActiveAction('workflowSaving'); this.uiStore.stateIsDirty = false; - this.$externalHooks().run('workflow.afterUpdate', { workflowData }); + void this.$externalHooks().run('workflow.afterUpdate', { workflowData }); getCurrentWorkflow(true); // refresh cache return true; diff --git a/packages/editor-ui/src/mixins/workflowRun.ts b/packages/editor-ui/src/mixins/workflowRun.ts index 2495794140acf..f2b777f974202 100644 --- a/packages/editor-ui/src/mixins/workflowRun.ts +++ b/packages/editor-ui/src/mixins/workflowRun.ts @@ -115,7 +115,7 @@ export const workflowRun = defineComponent({ duration: 0, }); this.titleSet(workflow.name as string, 'ERROR'); - this.$externalHooks().run('workflowRun.runError', { errorMessages, nodeName }); + void this.$externalHooks().run('workflowRun.runError', { errorMessages, nodeName }); await this.getWorkflowDataToSave().then((workflowData) => { this.$telemetry.track('Workflow execution preflight failed', { diff --git a/packages/editor-ui/src/views/NodeView.vue b/packages/editor-ui/src/views/NodeView.vue index bf80a59b0ffe6..f60fb0cea689c 100644 --- a/packages/editor-ui/src/views/NodeView.vue +++ b/packages/editor-ui/src/views/NodeView.vue @@ -220,7 +220,6 @@ import { workflowRun } from '@/mixins/workflowRun'; import NodeDetailsView from '@/components/NodeDetailsView.vue'; import Node from '@/components/Node.vue'; -import NodeSettings from '@/components/NodeSettings.vue'; import Sticky from '@/components/Sticky.vue'; import CanvasAddButton from './CanvasAddButton.vue'; import { v4 as uuid } from 'uuid'; @@ -314,7 +313,6 @@ interface AddNodeOptions { dragAndDrop?: boolean; } -const NodeCreator = async () => import('@/components/Node/NodeCreator/NodeCreator.vue'); const NodeCreation = async () => import('@/components/Node/NodeCreation.vue'); const CanvasControls = async () => import('@/components/CanvasControls.vue'); @@ -332,8 +330,6 @@ export default defineComponent({ components: { NodeDetailsView, Node, - NodeCreator, - NodeSettings, Sticky, CanvasAddButton, NodeCreation, @@ -641,11 +637,11 @@ export default defineComponent({ source: 'canvas', }; this.$telemetry.track('User clicked execute node button', telemetryPayload); - this.$externalHooks().run('nodeView.onRunNode', telemetryPayload); - this.runWorkflow(nodeName, source); + void this.$externalHooks().run('nodeView.onRunNode', telemetryPayload); + void this.runWorkflow(nodeName, source); }, async onRunWorkflow() { - this.getWorkflowDataToSave().then((workflowData) => { + void this.getWorkflowDataToSave().then((workflowData) => { const telemetryPayload = { workflow_id: this.workflowsStore.workflowId, node_graph_string: JSON.stringify( @@ -654,7 +650,7 @@ export default defineComponent({ ), }; this.$telemetry.track('User clicked execute workflow button', telemetryPayload); - this.$externalHooks().run('nodeView.onRunWorkflow', telemetryPayload); + void this.$externalHooks().run('nodeView.onRunWorkflow', telemetryPayload); }); await this.runWorkflow(); @@ -742,7 +738,7 @@ export default defineComponent({ this.canvasStore.zoomToFit(); this.uiStore.stateIsDirty = false; }); - this.$externalHooks().run('execution.open', { + void this.$externalHooks().run('execution.open', { workflowId: data.workflowData.id, workflowName: data.workflowData.name, executionId, @@ -818,7 +814,7 @@ export default defineComponent({ let data: IWorkflowTemplate | undefined; try { - this.$externalHooks().run('template.requested', { templateId }); + void this.$externalHooks().run('template.requested', { templateId }); data = await this.templatesStore.getWorkflowTemplate(templateId); if (!data) { @@ -846,7 +842,7 @@ export default defineComponent({ this.uiStore.stateIsDirty = true; }); - this.$externalHooks().run('template.open', { + void this.$externalHooks().run('template.open', { templateId, templateName: data.name, workflow: data.workflow, @@ -897,7 +893,7 @@ export default defineComponent({ this.uiStore.stateIsDirty = false; } this.canvasStore.zoomToFit(); - this.$externalHooks().run('workflow.open', { + void this.$externalHooks().run('workflow.open', { workflowId: workflow.id, workflowName: workflow.name, }); @@ -951,7 +947,7 @@ export default defineComponent({ return; } - this.callDebounced('onSaveKeyboardShortcut', { debounceTime: 1000 }, e); + void this.callDebounced('onSaveKeyboardShortcut', { debounceTime: 1000 }, e); return; } @@ -979,7 +975,7 @@ export default defineComponent({ if (e.key === 'Escape') { this.createNodeActive = false; if (this.activeNode) { - this.$externalHooks().run('dataDisplay.nodeEditingFinished'); + void this.$externalHooks().run('dataDisplay.nodeEditingFinished'); this.ndvStore.activeNodeName = null; } @@ -992,12 +988,12 @@ export default defineComponent({ } if (e.key === 'd') { - this.callDebounced('deactivateSelectedNode', { debounceTime: 350 }); + void this.callDebounced('deactivateSelectedNode', { debounceTime: 350 }); } else if (e.key === 'Delete' || e.key === 'Backspace') { e.stopPropagation(); e.preventDefault(); - this.callDebounced('deleteSelectedNodes', { debounceTime: 500 }); + void this.callDebounced('deleteSelectedNodes', { debounceTime: 500 }); } else if (e.key === 'Tab') { this.onToggleNodeCreator({ source: NODE_CREATOR_OPEN_SOURCES.TAB, @@ -1010,22 +1006,26 @@ export default defineComponent({ } else if (e.key === 'F2' && !this.isReadOnly) { const lastSelectedNode = this.lastSelectedNode; if (lastSelectedNode !== null && lastSelectedNode.type !== STICKY_NODE_TYPE) { - this.callDebounced('renameNodePrompt', { debounceTime: 1500 }, lastSelectedNode.name); + void this.callDebounced( + 'renameNodePrompt', + { debounceTime: 1500 }, + lastSelectedNode.name, + ); } } else if (e.key === 'a' && this.isCtrlKeyPressed(e) === true) { // Select all nodes e.stopPropagation(); e.preventDefault(); - this.callDebounced('selectAllNodes', { debounceTime: 1000 }); + void this.callDebounced('selectAllNodes', { debounceTime: 1000 }); } else if (e.key === 'c' && this.isCtrlKeyPressed(e)) { - this.callDebounced('copySelectedNodes', { debounceTime: 1000 }); + void this.callDebounced('copySelectedNodes', { debounceTime: 1000 }); } else if (e.key === 'x' && this.isCtrlKeyPressed(e)) { // Cut nodes e.stopPropagation(); e.preventDefault(); - this.callDebounced('cutSelectedNodes', { debounceTime: 1000 }); + void this.callDebounced('cutSelectedNodes', { debounceTime: 1000 }); } else if (e.key === 'n' && this.isCtrlKeyPressed(e) && e.altKey) { // Create a new workflow e.stopPropagation(); @@ -1059,7 +1059,7 @@ export default defineComponent({ e.stopPropagation(); e.preventDefault(); - this.callDebounced('selectDownstreamNodes', { debounceTime: 1000 }); + void this.callDebounced('selectDownstreamNodes', { debounceTime: 1000 }); } else if (e.key === 'ArrowRight') { // Set child node active const lastSelectedNode = this.lastSelectedNode; @@ -1075,7 +1075,7 @@ export default defineComponent({ return; } - this.callDebounced( + void this.callDebounced( 'nodeSelectedByName', { debounceTime: 100 }, connections.main[0][0].node, @@ -1087,7 +1087,7 @@ export default defineComponent({ e.stopPropagation(); e.preventDefault(); - this.callDebounced('selectUpstreamNodes', { debounceTime: 1000 }); + void this.callDebounced('selectUpstreamNodes', { debounceTime: 1000 }); } else if (e.key === 'ArrowLeft') { // Set parent node active const lastSelectedNode = this.lastSelectedNode; @@ -1107,7 +1107,7 @@ export default defineComponent({ return; } - this.callDebounced( + void this.callDebounced( 'nodeSelectedByName', { debounceTime: 100 }, connections.main[0][0].node, @@ -1179,7 +1179,7 @@ export default defineComponent({ } if (nextSelectNode !== null) { - this.callDebounced( + void this.callDebounced( 'nodeSelectedByName', { debounceTime: 100 }, nextSelectNode, @@ -1394,7 +1394,7 @@ export default defineComponent({ } this.stopExecutionInProgress = false; - this.getWorkflowDataToSave().then((workflowData) => { + void this.getWorkflowDataToSave().then((workflowData) => { const trackProps = { workflow_id: this.workflowsStore.workflowId, node_graph_string: JSON.stringify( @@ -1892,7 +1892,7 @@ export default defineComponent({ workflow_id: this.workflowsStore.workflowId, }); } else { - this.$externalHooks().run('nodeView.addNodeButton', { nodeTypeName }); + void this.$externalHooks().run('nodeView.addNodeButton', { nodeTypeName }); useSegment().trackAddedTrigger(nodeTypeName); const trackProperties: ITelemetryTrackProperties = { node_type: nodeTypeName, @@ -2938,7 +2938,7 @@ export default defineComponent({ is_welcome_note: node.name === QUICKSTART_NOTE_NAME, }); } else { - this.$externalHooks().run('node.deleteNode', { node }); + void this.$externalHooks().run('node.deleteNode', { node }); this.$telemetry.track('User deleted node', { node_type: node.type, workflow_id: this.workflowsStore.workflowId, @@ -3673,7 +3673,7 @@ export default defineComponent({ this.nodeCreatorStore.selectedView === TRIGGER_NODE_CREATOR_VIEW ? 'trigger' : 'regular'; if (createNodeActive === true) this.nodeCreatorStore.setOpenSource(source); - this.$externalHooks().run('nodeView.createNodeActiveChanged', { + void this.$externalHooks().run('nodeView.createNodeActiveChanged', { source, mode, createNodeActive, @@ -3832,7 +3832,7 @@ export default defineComponent({ }); // TODO: This currently breaks since front-end hooks are still not updated to work with pinia store - this.$externalHooks() + void this.$externalHooks() .run('nodeView.mount') .catch((e) => {});