diff --git a/packages/editor-ui/src/components/CredentialEdit/CredentialEdit.vue b/packages/editor-ui/src/components/CredentialEdit/CredentialEdit.vue index ee4f153951083..c19133e3dee1e 100644 --- a/packages/editor-ui/src/components/CredentialEdit/CredentialEdit.vue +++ b/packages/editor-ui/src/components/CredentialEdit/CredentialEdit.vue @@ -1115,8 +1115,6 @@ export default defineComponent({ oauthTokenData: {} as CredentialInformation, }; - this.credentialsStore.enableOAuthCredential(credential); - // Close the window if (oauthPopup) { oauthPopup.close(); diff --git a/packages/editor-ui/src/components/CredentialEdit/CredentialSharing.ee.vue b/packages/editor-ui/src/components/CredentialEdit/CredentialSharing.ee.vue index d01443ec35521..7c3381b9cce29 100644 --- a/packages/editor-ui/src/components/CredentialEdit/CredentialSharing.ee.vue +++ b/packages/editor-ui/src/components/CredentialEdit/CredentialSharing.ee.vue @@ -169,11 +169,9 @@ export default defineComponent({ : undefined; }, isCredentialSharedWithCurrentUser(): boolean { - return ( - Array.isArray(this.credentialData.sharedWithProjects) - ? this.credentialData.sharedWithProjects - : [] - ).some((sharee) => { + if (!Array.isArray(this.credentialData.sharedWithProjects)) return false; + + return this.credentialData.sharedWithProjects.some((sharee) => { return typeof sharee === 'object' && 'id' in sharee ? sharee.id === this.usersStore.currentUser?.id : false; diff --git a/packages/editor-ui/src/components/HoverableNodeIcon.vue b/packages/editor-ui/src/components/HoverableNodeIcon.vue index e51917b3e9c37..5f9110be6ac82 100644 --- a/packages/editor-ui/src/components/HoverableNodeIcon.vue +++ b/packages/editor-ui/src/components/HoverableNodeIcon.vue @@ -126,7 +126,7 @@ export default defineComponent({ const restUrl = this.rootStore.getRestUrl; - if (nodeType.icon && typeof nodeType.icon === 'string') { + if (typeof nodeType.icon === 'string') { const [type, path] = nodeType.icon.split(':'); const returnData: NodeIconData = { type, diff --git a/packages/editor-ui/src/stores/credentials.store.ts b/packages/editor-ui/src/stores/credentials.store.ts index d0b84e22940c8..44454c0f343ad 100644 --- a/packages/editor-ui/src/stores/credentials.store.ts +++ b/packages/editor-ui/src/stores/credentials.store.ts @@ -236,9 +236,6 @@ export const useCredentialsStore = defineStore(STORES.CREDENTIALS, { }; } }, - enableOAuthCredential(_credential: ICredentialsResponse): void { - // enable oauth event to track change between modals - }, async fetchCredentialTypes(forceFetch: boolean): Promise { if (this.allCredentialTypes.length > 0 && !forceFetch) { return; diff --git a/packages/editor-ui/src/views/TemplatesSearchView.vue b/packages/editor-ui/src/views/TemplatesSearchView.vue index 1567b1f81881d..05a2359ea5fe9 100644 --- a/packages/editor-ui/src/views/TemplatesSearchView.vue +++ b/packages/editor-ui/src/views/TemplatesSearchView.vue @@ -126,12 +126,7 @@ export default defineComponent({ const contentArea = document.getElementById('content'); if (contentArea) { // When leaving this page, store current scroll position in route data - if ( - this.$route.meta?.setScrollPosition && - typeof this.$route.meta.setScrollPosition === 'function' - ) { - this.$route.meta.setScrollPosition(contentArea.scrollTop); - } + this.$route.meta?.setScrollPosition?.(contentArea.scrollTop); } this.trackSearch();