This repository has been archived by the owner on Jun 19, 2020. It is now read-only.
Encoding binary file download POST parameters #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n1k0
added a commit
that referenced
this pull request
Sep 23, 2012
Encoding binary file download POST parameters
n1k0
added a commit
that referenced
this pull request
Sep 23, 2012
|
Thanks for contributing. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using casper.download() with unicode characters (é, á, ç, etc), sometimes it just garbled the response data and other times the request completely failed.
When replacing escape (https://github.com/n1k0/casperjs/blob/master/modules/clientutils.js#L317) by encodeURIComponent the issue is gone.
Not sure if it covers all the cases, but it works for me.
In any case, it could help someone else, so here it goes the pull request.