This repository has been archived by the owner on Jun 19, 2020. It is now read-only.
Fix Tester module and its selftest #266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n1k0
added a commit
that referenced
this pull request
Nov 2, 2012
Fix Tester module and its selftest
|
Thanks :) |
n1k0
added a commit
that referenced
this pull request
Nov 2, 2012
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The aliases for the Tester module's methods need to be included in the selftest.
Regression happened, and was not reported by the original selftest scripts. Specifically,
Tester.assertThrows()andTester.assertSelectorExists()were mis-declared and backwards compatibility broke.This contribution improves the selftest, and fixes the declarations of those 2 methods.
Notice - the selftest for the Tester module simply fails hard when undefined functions are called upon, and the bottom-line result of the selftest actually shows "green", whereas, scrolling through the full log will reveal "red" errors. This is because the selftest is not yet at the level of "let me assert that the method exists before I try to invoke it". Similar issues are likely to exist with all the other selftest scripts.