refactor(iroh): Remove custom impl of SharedAbortingJoinHandle
#2715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/2715/docs/iroh/ Last updated: 2024-09-06T10:05:11Z |
flub
approved these changes
Sep 6, 2024
flub
reviewed
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes our custom implementation of
SharedAbortingJoinHandlein favor of a combination offutures_util::future::Sharedfutures_util::future::MapErrandtokio_util::task::AbortOnDropHandleBreaking Changes
Should all be internal, so none.
Notes & open questions
We need to turn the
JoinErrorto aString, becauseJoinErroris!Send, butStringis.This is exactly the same behavior as what our custom
SharedAbortingJoinHandlewas doing before.Change checklist
[ ] Documentation updates following the style guide, if relevant.[ ] Tests if relevant.