fix(iroh-net): reduce noise in swarm discovery due to republish #2685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
divagant-martian
changed the title
matheus23
approved these changes
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since republish occurs more or less every second, for every peer in the local network, every second we insert it in the node_map (which includes locking), print a debug line, and for requesters, re-send a value that was previously sent (since every time a new sender is added we immediately send known values). This pr makes it so that we do all this only when new values are found.
Breaking Changes
Notes & open questions
the typo is unrelated to the pr but was flagged by ci
Change checklist
Documentation updates following the style guide, if relevant.Tests if relevant.