refactor(iroh-net): move all timeouts into one file

[ramfox]

Description

Co-locates all timeout defaults that have to do with making connections or running netcheck.

closes #2602

Notes & open questions

I nested some of the timeouts in another module (specifically the ones pertaining to the relay) but I could do this more for other sections, ie, the portmapper timeouts could be nested in a portmapper module.

Change checklist

• Self-review.
• Documentation updates following the style guide, if relevant.

[github-actions]

Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/2641/docs/iroh/

Last updated: 2024-08-19T16:34:33Z

[flub]

I'm kind of -1 on this. While it is nice and ordered right now I think it will be hard to maintain this. New timeouts will be added and not make it here because there's nothing naturally pointing here when you're in new code. const items are now also treated differently whether they're a timeout or something else which is also pretty arbitrary.

I agree it is nice to see everything in one place and with docs. Perhaps that's something that should be possible with a bit of grep though. (rg -B 3 ': Duration = Duration::from' is probably a decent start).

So I"m mainly worried this will result in a much messier code structure in the long term.

[dignifiedquire]

I'm kind of -1 on this. While it is nice and ordered right now I think it will be hard to maintain this.

Well this is the first round, eventually these will be configurable, making this more sensible I believe

[dignifiedquire]

@ramfox I don't think you are updating the DNS resolver configuration, or the quinn connection configuration yet

[ramfox]

@dignifiedquire we currently just use the defaults for quinn (10s) and the dns resolver (5s), so there are no consts to move around. The only places that we adjust the max_idle_timeout for quinn is in tests. And we have 2 consts for dns timeouts, one for netcheck and one for the client relay, but those are timeouts that wrap the dns resolver, so they can only shorten the timeout, not lengthen it.