feat(ci): notify discord of successfull flaky runs #2623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/2623/docs/iroh/ Last updated: 2024-08-14T02:24:02Z |
divagant-martian
changed the title
dignifiedquire
approved these changes
Aug 14, 2024
4 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 14, 2024
## Description in #2623 the condition for `notify` is not being cancelled, but a job can also be skipped. This is the output when a PR is not even running the tests. So, we get a good report in cases where there was no output. This fixes that issue ## Breaking Changes n/a ## Notes & open questions n/a ## Change checklist - [x] Self-review. - [ ] ~~Documentation updates following the [style guide](https://rust-lang.github.io/rfcs/1574-more-api-documentation-conventions.html#appendix-a-full-conventions-text), if relevant.~~ - [ ] ~~Tests if relevant.~~ - [ ] ~~All breaking changes documented.~~
matheus23
pushed a commit
that referenced
this pull request
Nov 14, 2024
## Description In pro of being a bit more positive, this PR makes the notify action tell us when there were no ci failures as well. ## Breaking Changes n/a ## Notes & open questions Also increases the required threads for the isolation tests ## Change checklist - [x] Self-review. - [ ] Documentation updates following the [style guide](https://rust-lang.github.io/rfcs/1574-more-api-documentation-conventions.html#appendix-a-full-conventions-text), if relevant. - [ ] Tests if relevant. - [ ] All breaking changes documented.
matheus23
pushed a commit
that referenced
this pull request
Nov 14, 2024
## Description in #2623 the condition for `notify` is not being cancelled, but a job can also be skipped. This is the output when a PR is not even running the tests. So, we get a good report in cases where there was no output. This fixes that issue ## Breaking Changes n/a ## Notes & open questions n/a ## Change checklist - [x] Self-review. - [ ] ~~Documentation updates following the [style guide](https://rust-lang.github.io/rfcs/1574-more-api-documentation-conventions.html#appendix-a-full-conventions-text), if relevant.~~ - [ ] ~~Tests if relevant.~~ - [ ] ~~All breaking changes documented.~~
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In pro of being a bit more positive, this PR makes the notify action tell us when there were no ci failures as well.
Breaking Changes
n/a
Notes & open questions
Also increases the required threads for the isolation tests
Change checklist