refactor(iroh-bytes)!: remove flume dependency #2622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
now that we have eliminated recv_timeout
we still have a dep via quic-rpc though...
rklaehn
changed the title
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/2622/docs/iroh/ Last updated: 2024-08-14T07:58:04Z |
rklaehn
force-pushed
the
flume-purge-bytes
branch
from
7654a88
to
e815643
Compare
|
@Frando this is similar to what you did with the docs store, I guess. The only difference is that I am using the main runtime to block on so you get the main blocking pool when calling spawn_blocking instead of the (single?) io thread of a single threaded runtime... |
dignifiedquire
approved these changes
Aug 14, 2024
2 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 2, 2024
…#2688) ## Description This fixes a small copy and paste bug that was introduced in #2622, here: https://github.com/n0-computer/iroh/pull/2622/files?diff=unified&w=0#diff-bbe46ca272a808bb1c94619ab3264586a47a6ec6e0f7cd5a63dba5e99099241bL1521-R1526 (You need to load the diff for the `fs.rs` file) <!-- A summary of what this pull request achieves and a rough list of changes. --> ## Breaking Changes <!-- Optional, if there are any breaking changes document them, including how to migrate older code. --> None ## Notes & open questions <!-- Any notes, remarks or open questions you have to make about the PR. --> Tests would be nice, but I'm looking at other things right now, so I'd prefer to merge this first :S ## Change checklist - [x] Self-review. - ~~[ ] Documentation updates following the [style guide](https://rust-lang.github.io/rfcs/1574-more-api-documentation-conventions.html#appendix-a-full-conventions-text), if relevant.~~ - ~~[ ] Tests if relevant.~~ - [x] All breaking changes documented.
matheus23
pushed a commit
that referenced
this pull request
Nov 14, 2024
## Description
This is mostly a pretty mechanical replacement of flume with
async_channel in the rebd blob store.
One not so tiny change is that to support closing a read or write
transaction after some delay, and because async_channel does not have
recv_timeout, we switch the entire actor loop to run *async* but on a
dedicated thread of the main runtime.
That way we can use `tokio::select! {..., timeout}`
## Breaking Changes
FlumeProgressSender was removed
## Notes & open questions
## Change checklist
- [ ] Self-review.
- [ ] Documentation updates following the [style
guide](https://rust-lang.github.io/rfcs/1574-more-api-documentation-conventions.html#appendix-a-full-conventions-text),
if relevant.
- [ ] Tests if relevant.
- [ ] All breaking changes documented.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is mostly a pretty mechanical replacement of flume with async_channel in the rebd blob store.
One not so tiny change is that to support closing a read or write transaction after some delay, and because async_channel does not have recv_timeout, we switch the entire actor loop to run async but on a dedicated thread of the main runtime.
That way we can use
tokio::select! {..., timeout}Breaking Changes
FlumeProgressSender was removed
Notes & open questions
Change checklist