chore(ci): use nextests groups to isolate some tests #2617
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After a lot of debugging we realized the integrations tests (
gc
tests, forexample) run with swarm discovery on since they are not technically using test
iroh, so they bypass the cfg that prevents it from being turned on. This causes
the
test_local_swarm_discovery
test to be flooded with nodes from othertests, making it flaky. Isolating the test should make it no longer flaky
anymore
Breaking Changes
n/a
Notes & open questions
We should still create a test that creates a bunch of nodes and makes sure they
all can find each other within reasonable time. There is still reason to
believe swarm discovery is slow, particularly in linux, but we should address
it in a test under our countrol, not via the non-deterministic nature of
concurrent tests in ci.
Change checklist
Documentation updates following the style guide, if relevant.Tests if relevant.All breaking changes documented.