fix(iroh-blobs): do not skip empty partial blobs in migration #2604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
divagant-martian
changed the title
ramfox
approved these changes
Aug 8, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 8, 2024
## Description When a blob found during migration is missing an outboard, according to the `cli_bao_store_migration` test, we should still migrate it. Before this change the blob would be ignored. This makes the test no longer broken. ## Breaking Changes n/a ## Notes & open questions 1. I can reproduce the failure 100% of the time, so before this change **I consider the test broken, not flaky.** 2. I reproduced the failure by running an iroh node with the exact v0 data the test uses. After the change, I did this again, and also ran both `validate` and `consistency-check` and got no errors. ## Change checklist - [x] Self-review. - [ ] ~~Documentation updates following the [style guide](https://rust-lang.github.io/rfcs/1574-more-api-documentation-conventions.html#appendix-a-full-conventions-text), if relevant.~~ - [ ] ~~Tests if relevant.~~ - [ ] ~~All breaking changes documented.~~
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When a blob found during migration is missing an outboard, according to the
cli_bao_store_migrationtest, we should still migrate it. Before this changethe blob would be ignored. This makes the test no longer broken.
Breaking Changes
n/a
Notes & open questions
validateandconsistency-checkand got no errors.Change checklist
Documentation updates following the style guide, if relevant.Tests if relevant.All breaking changes documented.