ref(iroh-net): Don't write the match as fully exhaustive #2585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it a bit earier to read. It's harder to figure out if thre are changes to the ConnectionType though, but let's assume that doesn't happen too often.
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/2585/docs/iroh/ Last updated: 2024-08-05T08:02:59Z |
Arqu
approved these changes
Aug 5, 2024
matheus23
approved these changes
Aug 5, 2024
There was a problem hiding this comment.
Yes, exactly what I was thinking of originally.
The main goal being: the exact effects of a transfer from connection type A to B on the metrics is easy to read off, similar to looking it up in a table.
I never intended the goal to be exhaustiveness checking & causing a compiler error in case ConnectionType gets modified.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This makes it a bit earier to read. It's harder to figure out if thre
are changes to the ConnectionType though, but let's assume that
doesn't happen too often.
Breaking Changes
None
Notes & open questions
I'm open to other ways of structuring this code. Not entirely sure
what the best shape would be.
Change checklist