refactor(iroh-net): replace flume in iroh-net with async_channel #2539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rklaehn
force-pushed
the
iroh-net-flume-purge
branch
2 times, most recently
from
99dae05
to
7eb882b
Compare
Rationale: see #2536
rklaehn
force-pushed
the
iroh-net-flume-purge
branch
from
7eb882b
to
6f60bd8
Compare
flub
approved these changes
Jul 24, 2024
matheus23
pushed a commit
that referenced
this pull request
Nov 14, 2024
## Description refactor(iroh-net): replace flume in iroh-net with async_channel Rationale: see #2536 This is the first in a series of PRs that will replace flume with async_channel. In this case it is very close to a drop in replacement without any need for changes. Only noteable changes: send_async becomes send send becomes send_blocking Receiver implements Stream, so no need for .into_stream() Receiver is not Unpin, so to make it unpin you need to do `Box::pin(recv)` or use `.boxed()` ## Breaking Changes None ## Notes & open questions - Anything specific from flume we were relying on here? ## Change checklist - [x] Self-review. - [x] ~~Documentation updates following the [style guide](https://rust-lang.github.io/rfcs/1574-more-api-documentation-conventions.html#appendix-a-full-conventions-text), if relevant.~~ - [x] ~~Tests if relevant.~~ - [x] ~~All breaking changes documented.~~
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
refactor(iroh-net): replace flume in iroh-net with async_channel
Rationale: see #2536
This is the first in a series of PRs that will replace flume with async_channel. In this case it is very close to a drop in replacement without any need for changes.
Only noteable changes:
send_async becomes send
send becomes send_blocking
Receiver implements Stream, so no need for .into_stream()
Receiver is not Unpin, so to make it unpin you need to do
Box::pin(recv)or use.boxed()Breaking Changes
None
Notes & open questions
Change checklist
Documentation updates following the style guide, if relevant.Tests if relevant.All breaking changes documented.