example(iroh): Improve and document custom-protocol example
#2468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Frando
force-pushed
the
example-custom-proto
branch
from
cae3c6f
to
0d8b44a
Compare
Frando
force-pushed
the
example-custom-proto
branch
from
0d8b44a
to
f98a416
Compare
matheus23
reviewed
Jul 8, 2024
iroh/examples/custom-protocol.rs
Outdated
| /// Query the local database. | ||
| /// | ||
| /// Returns the list of hashes of blobs which contain `query` literally. | ||
| pub async fn query_local(&self, query: &str) -> Result<Vec<Hash>> { |
There was a problem hiding this comment.
Suggested change
| pub async fn query_local(&self, query: &str) -> Result<Vec<Hash>> { | |
| pub fn query_local(&self, query: &str) -> Vec<Hash> { |
Needed to do this to fix some type error.
There was a problem hiding this comment.
uh yea thanks, this was a refactor leftover
matheus23
approved these changes
Jul 8, 2024
Frando
force-pushed
the
example-custom-proto
branch
from
f7a8dac
to
9a66926
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
custom-protocolexample to do something a bit more akin to something useful while still being conciseBreaking Changes
Notes & open questions
Change checklist