Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests(iroh): re-enable some flaky tests to see if they are still flaky #2458

Merged
merged 7 commits into from
Aug 15, 2024

Conversation

rklaehn
Copy link
Contributor

@rklaehn rklaehn commented Jul 4, 2024

Description

Breaking Changes

Notes & open questions

Change checklist

  • Self-review.
  • Documentation updates following the style guide, if relevant.
  • Tests if relevant.
  • All breaking changes documented.

@rklaehn rklaehn changed the title re-enable some flaky tests to see if they are still flaky tests(iroh): re-enable some flaky tests to see if they are still flaky Jul 4, 2024
@matheus23
Copy link
Contributor

Why is this a draft? Should we not merge this?

@dignifiedquire
Copy link
Contributor

@rklaehn ping, can we try and merge this?

@dignifiedquire dignifiedquire marked this pull request as ready for review August 8, 2024 12:44
@dignifiedquire dignifiedquire added this to the v0.23.0 milestone Aug 8, 2024
Copy link

github-actions bot commented Aug 8, 2024

Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/2458/docs/iroh/

Last updated: 2024-08-15T15:09:35Z

Copy link
Contributor

@divagant-martian divagant-martian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

haven't seen this fail for a long time in the scheduled flaky workflow

@divagant-martian divagant-martian added this pull request to the merge queue Aug 15, 2024
Merged via the queue into main with commit b8f2b3f Aug 15, 2024
28 checks passed
@rklaehn rklaehn deleted the unflakify branch August 16, 2024 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants