Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Reference rust doc style guide in contributing guidelines #2452

Merged
merged 6 commits into from
Jul 4, 2024

Conversation

flub
Copy link
Contributor

@flub flub commented Jul 3, 2024

Description

It is good for us to follow the common rust documentation style guide,
so explicitly reference this guide.

Breaking Changes

Notes & open questions

I'm effectively introducing a new policy here. Feel free to discuss.

Change checklist

  • Self-review.
  • Documentation updates if relevant.
  • [ ] Tests if relevant.
  • [ ] All breaking changes documented.

flub added 2 commits July 3, 2024 10:22
It is good for us to follow the common rust documentation style guide,
so explicitly reference this guide.
CONTRIBUTING.md Outdated Show resolved Hide resolved
Copy link
Contributor

@dignifiedquire dignifiedquire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agree with using this as a reference guide 👍

flub and others added 2 commits July 3, 2024 13:52
@divagant-martian divagant-martian added this pull request to the merge queue Jul 3, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 3, 2024
@flub flub enabled auto-merge July 4, 2024 09:33
@flub flub added this pull request to the merge queue Jul 4, 2024
Merged via the queue into main with commit 32b23e6 Jul 4, 2024
25 checks passed
@flub flub deleted the flub/contributing branch October 4, 2024 08:46
matheus23 pushed a commit that referenced this pull request Nov 14, 2024
## Description

It is good for us to follow the common rust documentation style guide,
so explicitly reference this guide.

## Breaking Changes

<!-- Optional, if there are any breaking changes document them,
including how to migrate older code. -->

## Notes & open questions

I'm effectively introducing a new policy here.  Feel free to discuss.

## Change checklist

- [x] Self-review.
- [x] Documentation updates if relevant.
- ~~[ ] Tests if relevant.~~
- ~~[ ] All breaking changes documented.~~

---------

Co-authored-by: Franz Heinzmann <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants