Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(iroh): Add rpc request to add an AddrInfo #2433

Merged
merged 3 commits into from
Jul 1, 2024
Merged

Conversation

rklaehn
Copy link
Contributor

@rklaehn rklaehn commented Jul 1, 2024

Description

Add rpc request to add an addr to an endpoint. Without this it is not possible to write some tests using just the client.
Move all node related fns into a separate "node client" and impl deref for it so the fns remain available on Iroh.

Breaking Changes

  • iroh::client::Iroh: stats only available via deref from iroh::client::node::Client
  • iroh::client::Iroh: connections only available via deref from iroh::client::node::Client
  • iroh::client::Iroh: connection_info only available via deref from iroh::client::node::Client
  • iroh::client::Iroh: status only available via deref from iroh::client::node::Client
  • iroh::client::Iroh: node_id only available via deref from iroh::client::node::Client
  • iroh::client::Iroh: node_addr only available via deref from iroh::client::node::Client
  • iroh::client::Iroh: home_addr only available via deref from iroh::client::node::Client
  • iroh::client::Iroh: shutdown only available via deref from iroh::client::node::Client

Notes & open questions

Change checklist

  • Self-review.
  • Documentation updates if relevant.
  • Tests if relevant.
  • All breaking changes documented.

otherwise it is impossible to write certain tests using just the client.
impl deref for backwards compat (maybe we can remove this at some point)
@rklaehn rklaehn requested a review from Frando July 1, 2024 09:36
@rklaehn rklaehn changed the title Add addr request feat(iroh): Add rpc request to add an AddrInfo Jul 1, 2024
@rklaehn rklaehn added this pull request to the merge queue Jul 1, 2024
Merged via the queue into main with commit 59e2719 Jul 1, 2024
24 of 28 checks passed
@rklaehn rklaehn mentioned this pull request Jul 1, 2024
4 tasks
@rklaehn rklaehn deleted the add-addr-request branch November 20, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants