Skip to content
This repository has been archived by the owner on Dec 18, 2023. It is now read-only.

running iroh p2p lookup gives Protocols (0) every time #70

Closed
b5 opened this issue Nov 21, 2022 · 2 comments · Fixed by n0-computer/iroh#537
Closed

running iroh p2p lookup gives Protocols (0) every time #70

b5 opened this issue Nov 21, 2022 · 2 comments · Fixed by n0-computer/iroh#537
Assignees
@ramfox
Labels
bug Something isn't working

Comments

@b5
Copy link
Member

b5 commented Nov 21, 2022

currently running lookup on main is missing a bunch of data that should be there:

Screen_Shot_2022-11-21_at_14 28 03

This is a regression. PR that fixes this should add a test
@dignifiedquire dignifiedquire added the bug Something isn't working label Nov 21, 2022
@ramfox
Copy link
Contributor

ramfox commented Nov 21, 2022

Looks like we have never fully implemented lookup for the local case!

fixing this now

@Arqu
Copy link
Collaborator

Arqu commented Nov 21, 2022

We had it working before. I specifically drilled us on this when we started bitswap debugging as I noticed we never properly responded to ipfs id or when telneting the p2p port. It's highly probable we didn't wire it up again after dig did the line by line port. For reference I'd look up that specific commit, pretty sure it is a smaller isolated one where it got hooked up.

@ramfox ramfox mentioned this issue Nov 21, 2022
Merged
@dignifiedquire dignifiedquire transferred this issue from n0-computer/iroh Feb 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ramfox ramfox

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(iroh-p2p): implement full local lookup n0-computer/iroh
4 participants
@dignifiedquire @b5 @Arqu @ramfox