Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: Gap Filling - Peak Finder #32

Open
dyrlund opened this issue Nov 6, 2015 · 5 comments
Open

Add: Gap Filling - Peak Finder #32

dyrlund opened this issue Nov 6, 2015 · 5 comments

Comments

@dyrlund
Copy link
Member

dyrlund commented Nov 6, 2015

No description provided.

@dyrlund dyrlund self-assigned this Feb 23, 2016
@dyrlund
Copy link
Member Author

dyrlund commented Feb 23, 2016

The new gap filling method uses the TargetedDetectionMethod from MSDK and is a merger of the following two old methods from MZmine 2:

  • Peak finder
  • Same RT and m/z range gap filter

@dyrlund
Copy link
Member Author

dyrlund commented Feb 24, 2016

@tomas-pluskal In MZmine 2 there is a RT correction option. In the code the following is stated:
Fill the gaps of a random sample using all the other samples...

Isn't the general idea behind the old correction the same as what we have now added as Use rows RT range and Use rows m/z range? At least I don't see a reason to keep this as a parameter in the new method. Do you have any objections against removing it?

@tomas-pluskal
Copy link
Member

I think this option was added by @SandraCastilloPriego
I have actually never tried using it, so I have no problem with removing it.
Sandra, do you have any comments?

@SandraCastilloPriego
Copy link

I don't remember about it. No problem if it is not useful.

On Wed, 24 Feb 2016 17:03 Tomáš Pluskal [email protected] wrote:

I think this option was added by @SandraCastilloPriego
https://github.com/SandraCastilloPriego
I have actually never tried using it, so I have no problem with removing
it.
Sandra, do you have any comments?


Reply to this email directly or view it on GitHub
mzmine/mzmine#32 (comment).

@dyrlund
Copy link
Member Author

dyrlund commented Mar 16, 2016

The initial version of the gap filling was done in MSDK #117.

However, the current implementation of the method is slow because the TargetedDetectionMethod is called multiple times for each sample. This should be optimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants