In browsers check for XMLHttpRequest, not window #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In nodejs testing environment it's possible to use https://github.com/tmpvar/jsdom library to define a window object, but you still want to use node http adapter. Due to those diverse testing environmnents, I propose to test for XMLHttpRequest directly, because window global object is not a sure sign of a browser environment anymore.
|
Thanks for the PR. Unfortunately |
Test for ActiveXObject
|
Damn, I always forget about those IE specialities. I added check for ActiveXObject, so now it should work in IE8 as well. |
|
Looks good. Thank you! |
mzabriskie
added a commit
that referenced
this pull request
Jul 23, 2015
In browsers check for XMLHttpRequest, not window
|
Thanks for merging this. Can you please also bump patch version? |
|
I'm working on getting a new release out soon. |
|
@tomaash I just released 0.6.0 which includes your PR. |
|
Cool, thanks! On Tue, Sep 22, 2015 at 12:58 AM, Matt Zabriskie [email protected]
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In nodejs testing environment it's possible to use https://github.com/tmpvar/jsdom library to define a window object, but you still want to use node http adapter. Due to those diverse testing environmnents, I propose to test for XMLHttpRequest directly, because window global object is not a sure sign of a browser environment anymore.