Http proxy support

[bomsy]

• Update documentation is specify proxy config
• Support for process.env.http_proxy / https_proxy / HTTP_PROXY / HTTPS_PROXY

[bomsy]

Should fix #107

[coveralls]

Coverage remained the same at 92.876% when pulling a70434b on bomsy:http_proxy-support into 54f3a5d on mzabriskie:master.

[nickuraltsev]

I suggest to refactor this a bit to eliminate duplication:

var proxy = config.proxy;
if (!proxy) {
 // try to retrieve proxy settings from env variables 
}

if (proxy) {
  // override options.host, options.port, and options.path
}

[nickuraltsev]

Thank you for the PR! It looks great. I have added some comments, please take a look.

[bomsy]

Thanks for the review. updates coming.

[coveralls]

Coverage remained the same at 92.876% when pulling d7ed28b on bomsy:http_proxy-support into 54f3a5d on mzabriskie:master.

[bomsy]

@nickuraltsev updated!

[nickuraltsev]

I think we should use the hostname property of the URL object rather than host. The latter contains the host name and the port (e.g. 'foo.com:8080'), which is not what should be passed to http.request (see https://nodejs.org/api/http.html#http_http_request_options_callback).

var parsedProxyUrl = url.parse(proxyUrl);
proxy = {
  host: parsedProxyUrl.hostname,
  port: parsedProxyUrl.port
};

[nickuraltsev]

@bomsy Thank you for the updates! I've just added one more comment.

[nickuraltsev]

@bomsy ping

[bomsy]

fixing the conflict now!

[coveralls]

Coverage remained the same at 92.876% when pulling 65cf8c5 on bomsy:http_proxy-support into 8abe0d4 on mzabriskie:master.

[bomsy]

done!

[nickuraltsev]

Looks like I was not clear enough (sorry for that!). My suggestion was to set the proxy.host to the proxy URL's hostname:

var parsedProxyUrl = url.parse(proxyUrl);
proxy = {
  host: parsedProxyUrl.hostname,
  port: parsedProxyUrl.port
};

Replacing proxy.host with proxy.hostname would be a breaking change, so I would prefer to avoid it.

Thank you for working on this!

[nickuraltsev]

@bomsy Hey! Are you still interested in working on this PR?

[bomsy]

@nickuraltsev hey ... yeah. been busy. will get it out in a bit.

[coveralls]

Coverage increased (+1.07%) to 93.947% when pulling 338a08f on bomsy:http_proxy-support into 8abe0d4 on mzabriskie:master.

[bomsy]

@nickuraltsev done!

[nickuraltsev]

@bomsy Thank you!

[ghost]

How do I tell if the version of axios I'm using has this fix?
I'm using v0.11.0 and I do set http_proxy and https_proxy before I make my request, but the script appears to ignore them.

[pbdm]

can we add change this line to var proxyUrl = process.env[proxyEnv] || process.env[proxyEnv.toUpperCase()] || process.env.all_proxy || process.env.ALL_PROXY] so that we can support all_proxy environment variables