-
-
Notifications
You must be signed in to change notification settings - Fork 11k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IE9 fix for cross domain calls #251
Conversation
I'm assuming that this works in all browsers (because travis is passing) Also, can I suggest that you rewrite your commit message to make it a little more clear? |
71cb22b
to
29f5b9b
Compare
I tested this change manually in Chrome/firefox/IE9/IE10/IE11. I updated the commit message. thanks for the suggestion !!! |
fixes #240 |
How does this work with the reference to |
Request is XDomainRequest and it has responseText property which retrieves the response body as a string. |
It's only |
@mzabriskie : For XMLHttpRequest we do get the response status. This scenario exists only for XDomainRequest. If you see this condition: ((response.status >= 200 && response.status < 300) || In 1st condition response status getting checked. For XMLHttpReuqest this 1st condition gets executed. For XDomainRequest we don't get the status in the response, that's why we need to check the request.responseText. |
Can you please merge this pull request if it looks ok ?..thanks ! |
IE9 fix for cross domain calls
Thank you for your PR! |
@ruchigoyal2005 @mzabriskie I'm still curious why this code rejects the promise in case when |
This pull request includes these fixes for IE9: