This repository has been archived by the owner on Oct 8, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 153
Add checkstyle at compile time #343
Open
oza
wants to merge
2
commits into
myui:master
Choose a base branch
from
oza:checkstyle
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oza
changed the title
Add checkstyle warnings at compile time
Add checkstyle at compile time
Sep 12, 2016
thanks for your work. Is this test failure expected?
|
The related topic is #215. Could you let us know the hadoop policy of check styles? |
You can check Hadoop Coding Style here. |
The compile failure is caused since the version of checkstyle plugin only supports JDK8. Re-seinding PR soon to fix it. |
okay, thanks. |
Signed-off-by: Tsuyoshi Ozawa <[email protected]>
I think we need to at least turn off check-style warning logs for |
cc: @myui |
@oza Could you move this PR to https://github.com/apache/incubator-hivemall |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables compile-time coding style check by using maven-checkstyle-plugin.
Please run:
and it shows you the warning and error messages, based on Google Java Coding Style in maven-checkstyle-plugin: http://checkstyle.sourceforge.net/google_style.html
https://google.github.io/styleguide/javaguide.html