Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

es/no-promise-prototype-finally doesn't work #59

Open
dormd opened this issue Jan 11, 2021 · 5 comments
Open

es/no-promise-prototype-finally doesn't work #59

dormd opened this issue Jan 11, 2021 · 5 comments

Comments

@dormd
Copy link

dormd commented Jan 11, 2021

Hi, I'm using version 4.1.0.
I'm getting the following error when using es/no-promise-prototype-finally
1:1 error Definition for rule 'es/no-promise-prototype-finally' was not found es/no-promise-prototype-finally

This is my eslint config:

module.exports = {
  parserOptions: {
    ecmaVersion: 5
  },
  extends: [
    'eslint:recommended',
    'plugin:jest/recommended',
    'plugin:es/restrict-to-es5'
  ],
  plugins: [
    'jest',
    'es'
  ],
  rules: {
    'es/no-promise-prototype-finally': 2,
    'es/no-promise': 0,
  },
  env: {
    node: true,
    browser: true,
    'jest/globals': true
  },
  settings: {
    es: { aggressive: true }
  },
  globals: {
    Promise: true
  }
};

Any advice?

@laserval
Copy link

The prototype rules appear to have been added after the latest release:

@dormd
Copy link
Author

dormd commented Mar 16, 2021

@laserval when will you deploy the next version containing these changes?

@laserval
Copy link

@laserval when will you deploy the next version containing these changes?

I'm not the maintainer, just a user. I'd also welcome a release, just discovered this library and the prototype rules would be great.

@mysticatea is there anything that needs to be done to get things in order for a release?

@maxclaus
Copy link

While that is not released I have installed it directly from GitHub instead of NPM.

@legend80s
Copy link

same problem any progress?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants