Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Health Checks in MySqlDataSourceBuilder #1368

Closed
bgrainger opened this issue Sep 9, 2023 · 2 comments
Closed

Support Health Checks in MySqlDataSourceBuilder #1368

bgrainger opened this issue Sep 9, 2023 · 2 comments

Comments

@bgrainger
Copy link
Member

There is an existing MySQL health checks package: https://www.nuget.org/packages/AspNetCore.HealthChecks.MySql

It is just initialized from a connection string, so it doesn't integrate with MySqlDataSource, use the logging that's configured, etc.

Design a mechanism to support health checks (perhaps an extension method on MySqlDataSourceBuilder, perhaps in MySqlConnector.DependencyInjection or perhaps in a new package) that integrates easily with a MySqlDataSource.

@bgrainger
Copy link
Member Author

Support for MySqlDataSource has been added here: Xabaril/AspNetCore.Diagnostics.HealthChecks#2096.

If that PR is merged, we should endorse the community-created health checks library instead of creating our own version.

@bgrainger
Copy link
Member Author

https://www.nuget.org/packages/AspNetCore.HealthChecks.MySql should be used for ASP.NET Core health checks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

1 participant