Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove new FormatException() #1114

Closed
bgrainger opened this issue Jan 7, 2022 · 2 comments
Closed

Remove new FormatException() #1114

bgrainger opened this issue Jan 7, 2022 · 2 comments
Labels
enhancement

Comments

@bgrainger
Copy link
Member

Replace all instances of new FormatException() with a more detailed message explaining what was expected and what was found instead.

This will improve the user experience for scenarios such as https://stackoverflow.com/questions/70624373/error-when-trying-to-get-data-from-mysql-using-entityframeworkcore.
@bgrainger
Copy link
Member Author

The only new FormatException() instances that need to be changed are the ones parsing a CHAR(36) or CHAR(32) as a Guid; every other one assumes the server will implement the text protocol correctly and not send malformed data.

@bgrainger
Copy link
Member Author

Fixed in 2.1.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bgrainger