Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export debates without GID #1847

Merged
merged 1 commit into from
Dec 11, 2024
Merged

Export debates without GID #1847

merged 1 commit into from
Dec 11, 2024

Conversation

ajparsons
Copy link
Contributor

Joining with the other tables to map GIDs to debates loses the (few, but all relevant to policies) - pre 2004 votes.

As a result, doing a union with just the divisions in there with no GID.

@ajparsons ajparsons requested a review from dracos November 19, 2024 09:01
Copy link
Member

@dracos dracos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tested this works okay? It feels like there should be a nicer way to do this than a UNION, but anything I tried was incredibly slow, perhaps you've found the same.

@ajparsons
Copy link
Contributor Author

Yeah, I tried a few different join approaches but they were very slow. Fully concede this is a horrible query.

(I guess the long term alternative it is to go in and add the gids, but this is the path of least resistance).

@ajparsons ajparsons merged commit 2d675eb into master Dec 11, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants